Repository navigation
Enable email notifications for messages/test_email_*.py - #1095
Merged
mdujava merged 2 commits intoSep 25, 2026
Merged
Conversation
cathal-bailey
changed the title
mdujava
requested changes
Aug 27, 2026
mdujava
left a comment
mdujava
left a comment
Member
There was a problem hiding this comment.
I would like this test to stay non-disruptive, therefor not to use session fixture that changes all accounts or any rake commands if that's not documented way how to update notification settings.
cathal-bailey
marked this pull request as ready for review
September 1, 2026 14:32
cathal-bailey
force-pushed
the
enable-email-notifications
branch
from
September 11, 2026 12:55
44449b3 to
a88aa9a
Compare
mdujava
requested changes
Sep 11, 2026
mdujava
approved these changes
Sep 14, 2026
mastastny
approved these changes
Sep 24, 2026
Updating notification list to enable service_deleted Updating comment for assert Enabling notifications through API enpoints rather than rails runner Adding .* wildcard after the Email field in mail_templates.yml
mdujava
force-pushed
the
enable-email-notifications
branch
from
September 25, 2026 15:04
3f36de6 to
32218ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After porta PR #4039 was merged in Alpha build, email notifications changed from account-level to per-user NotificationPreferences. Fresh 3scale deployments have notifications disabled by default, causing all email notification tests to fail.
conftest.pyfixture to automatically enable required notifications (account_created, application_created, service_contract_created, account_deleted) before tests runKeyErrorintest_email_accounts.py:100when assertion fails (assert comment tried to accesstpl['Headers'], which doesn't exist)MailhogClient.request()to handle stale connections between tests, fixing ConnectionError exceptionsContact Namefield in account signup notification emails. Added.*wildcard regex to absorb optional fields.