Repository navigation
📝 docs: bring CLAUDE.md and the package comment up to date after PPTX - #90
Conversation
CLAUDE.md still described slideModeCSS, removed when decks got their own stylesheet, listed formats without pptx, and said stdin needs -o only for pdf and docx. The converter package comment still said PDF printing went through the Playwright Python driver. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe documentation now describes PPTX support, the Chromium DevTools Protocol pipeline, HTML and PPTX behavior, and the current slide CSS assembly. ChangesDocumentation alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the slides with care Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b220ad6bb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // | ||
| // DOCX output is produced directly from Markdown by pandoc, and console output | ||
| // is rendered to ANSI text by glamour; both bypass the HTML stage. | ||
| // HTML output stops after the third stage's HTML file. PPTX output renders the |
There was a problem hiding this comment.
When Markdown contains ordinary local images, FormatHTML returns before copyImages and deliberately leaves those image references external, as CLAUDE.md itself notes. By identifying HTML output with the “self-contained” stage described above, this comment can lead callers to move or distribute the HTML alone and get broken images; qualify that only CSS, fonts, and rendered Mermaid SVGs are embedded, while user images remain external.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed: the comment now says HTML output is self-contained except for local images, which keep the relative paths the Markdown gave them rather than being copied.
Codex review on #90. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 participant
Summary
Documentation cleanup after the PPTX epic (#72). No behavior change.
Refs #72
Changes
slideModeCSS, which feat: add a slide stylesheet and the class directive #76 replaced withslideBaseCSS; the page-break,overflow: hiddenand body-padding rules are now described where they actually live (slideBaseCSS), andslideSizeCSSis described as what it now does (fixed slide size plus@pagesize).Config.Formatlistspptx; the Config summary names the slide options (Slides,PaperFlagsSet); "all three pipelines" → "every pipeline".resolveOutputPath:-ois required from stdin for every file format (pdf, html, pptx, docx), not just pdf/docx — matchinginputs.go.resolveFormatinfers pptx from.pptx;-doctorblocks pptx as well as pdf on a missing Chromium.internal/converter/converter.gopackage comment: said PDF was printed "via the Playwright Python driver", which has not been true since chromedp replaced it; now also mentions HTML and PPTX output. The remaining "Playwright" mentions in the code are about where Chromium is searched for (Playwright's browser cache) and are still accurate.Local-only cleanup also done: the eight merged
feat/73–feat/80branches were deleted locally (their remote branches were already gone).Not changed
origin/feat/44-mermaid-ascii-artis left in place: its PR #47 was closed without merging and it holds three commits that are not onmain, so deleting it would lose work. Remove it by hand if it is no longer needed.Tests
go vet ./...,go test ./...,golangci-lint run ./...(0 issues).🤖 Generated with Claude Code
Summary by CodeRabbit
.pptxto the documented output extension options.