Add note filter by script root - #249
Open
gabrielbosio wants to merge 17 commits into
Open
Conversation
gabrielbosio
changed the title
…napshot The test wiped IndexedDB under the live client and imported into the empty store, which cannot resolve any block header. Restoring a pre-mint snapshot keeps the scenario (note gone, chain known) without relying on client state that a store wipe invalidates.
seed_transaction_encryption_key is async and fallible on the pinned rust-sdk rev; the un-awaited call dropped the future, so mock clients never actually held a key and every submission would fail to seal.
…nding The ThreadRng temporary used to derive the mock encryption key lived across the seeding await, and napi requires Send futures. Generate the key before the call so the RNG is dropped first.
gabrielbosio
force-pushed
the
note_filter_script_root
branch
from
July 29, 2026 15:23
1b73926 to
477ca55
Compare
gabrielbosio
marked this pull request as ready for review
July 30, 2026 13:24
next moved the client crates from crates.io versions to git dependencies on rust-sdk next, which left this branch's [patch.crates-io] block matching no source. Point the workspace dependencies at the rust-sdk note_filter_script_root branch instead (e70d3df8, which merges rust-sdk next) and drop the dead patch block, so the store-level script root filter is still compiled in. MIDEN_CLIENT_REF follows the same rev. Cargo.lock keeps next's graph: only the two client sources change, the node rev and protocol versions are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.