fix(store): write transaction scripts atomically - #219
Open
skyc1e wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216.
upsert_transaction_recordwrote the transaction script and transaction record through separate IndexedDB promises. If the record write failed after the script insert, the script could remain intransactionScriptswithout any transaction referencing it.This adds a small JS wrapper that writes both pieces inside one Dexie transaction and switches the Rust wasm binding to call that wrapper. The lower-level helpers stay in place for existing callers.
Checked with:
cmd /c ..\..\..\node_modules\.bin\vitest.cmd run --config vitest.config.ts ts/transactions.test.tscmd /c ..\..\..\node_modules\.bin\tsc.cmd --noEmit --project tsconfig.jsongit diff --check