docs: add shared wallet frontend skill - #515
Merged
Merged
Conversation
0xnullifier
approved these changes
Aug 10, 2026
0xnullifier
left a comment
0xnullifier
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one change
|
|
||
| ## Interaction Requirements | ||
|
|
||
| Use a native `button` for an action and an `a` for navigation whenever possible. Icon-only controls need an accessible name. Status or asynchronous completion needs the right `role` or live-region behavior. Keyboard users must receive the same action with Enter and Space when a custom control is unavoidable. |
Collaborator
There was a problem hiding this comment.
I would say use the components/Button.tsx instead of bare button everywhere
Collaborator
Author
There was a problem hiding this comment.
missed this suggestion, let me add this in a seperate PR and then merge it again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one vendor-neutral Miden Wallet frontend skill and exposes it to both Claude and Codex through project-local links. The skill codifies component reuse, semantic styling, motion, accessibility, haptics, platform constraints, and verification.
The repository instructions now carry the same concise frontend baseline, while the detailed guidance remains in the shared skill.
Validation
quick_validate.pypasses forskills/miden-wallet-frontend..agents/skills/miden-wallet-frontendand.claude/skills/miden-wallet-frontendresolve to the canonical skill directory.git diff --checkand post-commitgit show --checkpass.Test plan
Out of scope