refactor(sync): split sync_state into sync_chain and sync_note_transport for granularity

CHANGELOG.md

@@ -18,6 +18,7 @@
 
 ### Enhancements
 
+* [FEATURE][rust] Added `Client::sync_chain()` (on-chain sync only) and `Client::sync_note_transport()` (Note Transport Layer fetch only) for callers needing finer-grained control over sync. ([#2091](https://github.com/0xMiden/miden-client/pull/2091))
 * [FEATURE][rust] Added `GrpcClient::with_bearer_auth(token)` to attach an `authorization: Bearer <token>` header to every outbound gRPC call, for use behind authenticating gateways. Tokens are validated at connection time and preserved across `set_genesis_commitment` updates ([#2101](https://github.com/0xMiden/miden-client/pull/2101)).
 * Made new-account construction use merged storage schema commitment (`build_with_schema_commitment`), re-exported `AccountBuilderSchemaCommitmentExt`, added WASM `buildWithoutSchemaCommitment()`, and fixed contract `accounts.create()` to require explicit `components` ([#1996](https://github.com/0xMiden/miden-client/pull/1996)).
 * Fixed the faucet token symbol display when showing account details ([#1985](https://github.com/0xMiden/miden-client/pull/1985)).

crates/rust-client/src/sync/mod.rs

@@ -100,8 +100,12 @@ where
         self.store.get_sync_height().await.map_err(Into::into)
     }
 
-    /// Syncs the client's state with the current state of the Miden network and returns a
-    /// [`SyncSummary`] corresponding to the local state update.
+    /// Syncs the client's on-chain state with the current state of the Miden network and returns
+    /// a [`SyncSummary`] corresponding to the local state update.
+    ///
+    /// Does **not** fetch private notes from the Note Transport Layer. Use
+    /// [`Client::sync_state`] for the combined sync, or call [`Client::sync_note_transport`]
+    /// separately.
     ///
     /// The sync process is done in multiple steps:
     /// 1. A request is sent to the node to get the state updates. This request includes tracked
@@ -119,18 +123,10 @@ where
     ///    state.
     /// 7. The MMR is updated with the new peaks and authentication nodes.
     /// 8. All updates are applied to the store to be persisted.
-    pub async fn sync_state(&mut self) -> Result<SyncSummary, ClientError> {
+    pub async fn sync_chain(&mut self) -> Result<SyncSummary, ClientError> {
         self.ensure_genesis_in_place().await?;
         self.ensure_rpc_limits_in_place().await?;
 
-        // Note Transport update
-        // TODO We can run both sync_state, fetch_transport_notes futures in parallel
-        if self.is_note_transport_enabled() {
-            let cursor = self.store.get_note_transport_cursor().await?;
-            let note_tags = self.store.get_unique_note_tags().await?;
-            self.fetch_transport_notes(cursor, note_tags).await?;
-        }
-
         // Build sync state components
         let note_screener = self.note_screener();
         let state_sync = StateSync::new(
@@ -164,6 +160,29 @@ where
         Ok(sync_summary)
     }
 
+    /// Fetches private notes from the Note Transport Layer for the tracked note tags.
+    ///
+    /// No-op if note transport is disabled.
+    pub async fn sync_note_transport(&mut self) -> Result<(), ClientError> {
+        if !self.is_note_transport_enabled() {
+            return Ok(());
+        }
+
+        let cursor = self.store.get_note_transport_cursor().await?;
+        let note_tags = self.store.get_unique_note_tags().await?;
+        self.fetch_transport_notes(cursor, note_tags).await
+    }
+
+    /// Runs [`Client::sync_note_transport`] followed by [`Client::sync_chain`], failing fast on
+    /// the first error.
+    ///
+    /// Note: private notes delivered via NTL are imported before
+    /// the chain sync reads its input set, so their nullifiers are checked in the same call.
+    pub async fn sync_state(&mut self) -> Result<SyncSummary, ClientError> {
+        self.sync_note_transport().await?;
+        self.sync_chain().await
+    }
+
     /// Builds a default [`StateSyncInput`] from the current client state.
     ///
     /// This includes all tracked account headers, all unique note tags, all unspent input and