fix(standards): reject faucets whose policies lack their required storage slots - #3527
Open
onurinanc wants to merge 3 commits into
Open
fix(standards): reject faucets whose policies lack their required storage slots#3527onurinanc wants to merge 3 commits into
onurinanc wants to merge 3 commits into
Conversation
bobbinth
reviewed
Aug 7, 2026
Comment on lines
+560
to
+570
| let account = NetworkAccount::builder(init_seed, note_allowlist, fee_policy_manager) | ||
| .expect("MintNote + BurnNote allowlist is non-empty") | ||
| .with_component(faucet) | ||
| .with_components(access_control) | ||
| .with_components(token_policy_manager) | ||
| .with_component(Pausable::unpaused()) | ||
| .with_component(PausableManager) | ||
| .build() | ||
| .map_err(NonFungibleFaucetError::AccountCreationFailed) | ||
| .map_err(NonFungibleFaucetError::AccountCreationFailed)?; | ||
|
|
||
| verify_policy_dependencies(&required_slots, account.storage())?; |
Contributor
There was a problem hiding this comment.
A preliminary question: should this check be actually happening in the AccountBuilder? This would be a more general solution, but probably a bit more difficult to implement (or at least to design).
If we do decide to how this route, the way to implement this is to specify dependencies at the AccountComponentMetadata level. Then, the builder would be able to read dependencies of all components and verify that they are all satisfied.
I think the main complexity here would come from figuring out how to specify dependencies. The approach taken in this PR is to use just slot names. Maybe this is enough, but maybe we want to list actual components as dependencies too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3526