refactor: remove asset value from callback outputs - #3513
Conversation
partylikeits1983
added
kernels
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good! I left a few suggestions.
# Conflicts: # crates/miden-standards/asm/standards/faucets/policies/transfer/basic_allowlist.masm # crates/miden-standards/asm/standards/faucets/policies/transfer/basic_blocklist.masm
zeapoz
left a comment
zeapoz
left a comment
There was a problem hiding this comment.
Looks good to me! Just two comments about the changelog
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one comment inline. The code technically works there, but should be improved because the pattern is used incorrectly. But we can fix it in a small follow-up.
| # No policy configured: consume the callback inputs. | ||
| dropw dropw dropw drop | ||
| # => [pad(16)] |
There was a problem hiding this comment.
This happens to work because this procedure is always invoked as a last thing in a call-ed procedure, but I don't think we should be doing this - at least not without being super explicit about the invocation context in the comments.
Better yet, we should change the signature to something like:
#! Inputs: [slot_id_suffix, slot_id_prefix, ASSET_ID, ASSET_VALUE, custom_data]
#! Outputs: []
And handle padding adjustments at the callsites.
4 participants
Closes #3505.