chore: take proof by reference in verify - #3469
Open
PhilippGackstatter wants to merge 5 commits into
Open
Conversation
PhilippGackstatter
marked this pull request as ready for review
August 5, 2026 11:59
huitseeker
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some small improvement suggestions coming from the review of 0xMiden/protocol#3492.
verify,Verifier::verify, andVerifier::verify_partialnow borrow&ExecutionProofand&ExecutionClaiminstead of consuming them. Consuming them forced any caller that still needs them to clone the entire proof (serialized size 114 KB).verify_partialis included for consistency, since it has the same shape and sits next toverifyin the public API.AdviceMutationfields to say what they hold:ExtendMap { other }becomesExtendMap { map }ExtendMerkleStore { infos }becomesExtendMerkleStore { inner_nodes }Checklist before requesting a review
nextaccording to naming convention.CHANGELOG.md