-
Notifications
You must be signed in to change notification settings - Fork 320
feat(mmr): add authenticated rooted-frontier path #3184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
krushimir
wants to merge
3
commits into
0xMiden:main
Choose a base branch
from
reilabs:krushimir/mmr-frontier-root
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| use miden_assembly::Assembler; | ||
| use miden_core_lib::CoreLibrary; | ||
| use miden_processor::{DefaultHost, FastProcessor, Felt, Program, StackInputs, Word, ZERO}; | ||
|
|
||
| pub fn compile(core_lib: &CoreLibrary, source: &str) -> Program { | ||
| Assembler::default() | ||
| .with_static_library(core_lib.library()) | ||
| .expect("link core library") | ||
| .assemble_program(source) | ||
| .expect("assemble benchmark program") | ||
| } | ||
|
|
||
| pub fn processor_inputs(core_lib: &CoreLibrary) -> (DefaultHost, FastProcessor) { | ||
| let mut host = DefaultHost::default(); | ||
| host.load_library(core_lib).expect("load core library host data"); | ||
| (host, FastProcessor::new(StackInputs::default())) | ||
| } | ||
|
|
||
| pub fn push_word(word: Word) -> String { | ||
| let [a, b, c, d]: [Felt; 4] = word.into(); | ||
| format!( | ||
| "push.{}.{}.{}.{}", | ||
| d.as_canonical_u64(), | ||
| c.as_canonical_u64(), | ||
| b.as_canonical_u64(), | ||
| a.as_canonical_u64(), | ||
| ) | ||
| } | ||
|
|
||
| pub fn word_from_u64(value: u64) -> Word { | ||
| [ZERO, ZERO, ZERO, Felt::new_unchecked(value)].into() | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we either zero the padded peak words here, or assert that they are zero?
unpack_frontierwrites all padded words from advice into MMR memory, butroot_from_peak_endonly authenticates the real peaks beforepeak_end. So the same(num_leaves, ROOT)can be accepted with different non-zero padding, and a latermmr::packwill hash those padding slots into a different legacy commitment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
unpack_frontiernow zeroes the padded peak slots after loading them from advice. The root check still only uses the real peaks, but the memory layout is now canonical, so a latermmr::packcannot hash non-zero padding.Added a regression test for this.