fix(codegen): check narrowed int32 operand - #1195
Open
1sgtpepper wants to merge 1 commit into
Open
Conversation
1sgtpepper
marked this pull request as ready for review
June 18, 2026 23:44
1sgtpepper
force-pushed
the
fix-int32-uint-narrowing-1182
branch
from
June 21, 2026 20:44
a2cf5b6 to
c116211
Compare
bitwalker
requested changes
Jun 23, 2026
1sgtpepper
force-pushed
the
fix-int32-uint-narrowing-1182
branch
from
July 11, 2026 00:08
c3d8385 to
b9a0e40
Compare
Author
|
@bitwalker Could you approve the CI run? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1182
int32_to_uintandtry_int32_to_uintwere duplicating the word below the value being narrowed before applying the unsigned range mask. With another live value below the operand, checked narrowing could reject a valid value or accept an out-of-range value based on the wrong stack word.This changes both helpers to duplicate the top stack value before masking. The full-width
n == 32case uses a zero mask so the mask construction does not shift by 32.Regression coverage compiles HIR snippets and executes them through the package evaluator:
u32andi32toi1,u8, andu16;u8addition, which covers thetry_int32_to_uintpath;dup.1behavior fails on both valid and invalid inputs.