Some calls to `Event::Event` ctor require a very particular load sequence from .data section

[robojumper]

The ctor at 800a0c40 is sometimes called with a pattern like this:

ss/src/REL/d/t/d_t_ship_window.cpp

Lines 82 to 88 in 22a5cad

	// this works but I don't like it
	static volatile u32 FLAGS_1 = 0x00000001;
	static u32 FLAGS_2 = 0x00100001;
	u32 f1 = FLAGS_1;
	u32 f2 = FLAGS_2;
	Event e = Event(mOffEventId, roomid, f2 & ~f1, nullptr, nullptr);
	mEvent.scheduleEvent(e, 0);

Every call has its own copy of these statics even within the same file, and the volatile seems to be required to load them in the right order. This looks like an obvious hack but we haven't found a good way to match it...

[elijah-thomas774]

Another thing to note:
0x00100001 is a common parameter to creating an event.
This usually is an immediate load, but in the cases of & ~f1 both become data. f1 is also consistently 0x00000001 in these cases

[elijah-thomas774]

#107 has an instance where it doesnt follow this

[robojumper]

Just so this doesn't get lost, Esme found out that an inline function like static u32 makeEventFlag(const u32 &p1, const u32 &p2) { ... } causes these constants to be emitted to a data section too. That hasn't completely solved the problem but it looks much more reasonable.

[elijah-thomas774]

using an inline with const references seems to work mostly.

I am wondering if there was a wrapper for this field like:

struct EventBits {
    u32 bits;
};

And this is causing some odd behavior.

in

ss/src/REL/d/a/obj/d_a_obj_door.cpp

Lines 1336 to 1343 in a67ebab

	inline u32 createBits(const u32 &a, const u32 &b) {
	return a | b;
	}
	void dAcOdoor_c::startPullEventWithoutCallback(void *zevData) {
	Event event(DoorPull, zevData, 100, createBits(0x100001, 0x2), nullptr, nullptr);
	mEventRelated.scheduleEvent(event, 0);
	}

I had a similar situation using an or and this worked.

0x100001 may have been a default setting and users needed to modify the default