Skip to content

feat(router): observe subscription delivery failures - #3173

Draft
mwisner wants to merge 5 commits into
wundergraph:mainfrom
mwisner:mwisner/feat/subscription-delivery-diagnostics
Draft

feat(router): observe subscription delivery failures#3173
mwisner wants to merge 5 commits into
wundergraph:mainfrom
mwisner:mwisner/feat/subscription-delivery-diagnostics

refactor(router): keep delivery diagnostics transport-local

e3ed5f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2026 in 0s

53.74% (target 30.00%)

View this Pull Request on Codecov

53.74% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 64.10256% with 154 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.74%. Comparing base (9ddb729) to head (e3ed5f4).

Files with missing lines Patch % Lines
router/core/subscription_response_writer.go 56.38% 38 Missing and 3 partials ⚠️
router/core/subscription_delivery_observability.go 78.43% 28 Missing and 5 partials ⚠️
router/core/websocket.go 63.73% 33 Missing ⚠️
router/pkg/metric/engine_metrics.go 39.13% 24 Missing and 4 partials ⚠️
router/pkg/statistics/engine_stats.go 0.00% 11 Missing ⚠️
router/core/graphql_handler.go 80.95% 3 Missing and 1 partial ⚠️
router/pkg/config/config.go 0.00% 1 Missing and 1 partial ⚠️
router/pkg/config/json_schema.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3173      +/-   ##
==========================================
+ Coverage   45.47%   53.74%   +8.27%     
==========================================
  Files         148      249     +101     
  Lines       14130    31127   +16997     
  Branches      838        0     -838     
==========================================
+ Hits         6425    16730   +10305     
- Misses       7703    12750    +5047     
- Partials        2     1647    +1645     
Files with missing lines Coverage Δ
router/core/graph_server.go 83.51% <100.00%> (ø)
router/pkg/otel/attributes.go 62.50% <ø> (ø)
router/pkg/config/config.go 56.63% <0.00%> (ø)
router/pkg/config/json_schema.go 36.00% <80.00%> (ø)
router/core/graphql_handler.go 57.78% <80.95%> (ø)
router/pkg/statistics/engine_stats.go 5.55% <0.00%> (ø)
router/pkg/metric/engine_metrics.go 65.33% <39.13%> (ø)
router/core/subscription_delivery_observability.go 78.43% <78.43%> (ø)
router/core/websocket.go 63.82% <63.73%> (ø)
router/core/subscription_response_writer.go 69.19% <56.38%> (ø)

... and 387 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.