Bookmarking In Android

[AnsifDev]

We can actually omit the prefix to determine wheather it is a uri or file path. Code below is the rectified one. This makes the bookmark data pretty straight, meaning full and less error prone

public actual suspend fun PlatformFile.bookmarkData(): BookmarkData = withContext(Dispatchers.IO) {
    when (androidFile) {
        is AndroidFile.FileWrapper -> {
            val data = androidFile.file.path
            BookmarkData(data.encodeToByteArray())
        }

        is AndroidFile.UriWrapper -> {
            val uri = androidFile.uri
            val authority = uri.authority ?: throw FileKitException("Uri authority is null")

            val flags = Intent.FLAG_GRANT_READ_URI_PERMISSION or Intent.FLAG_GRANT_WRITE_URI_PERMISSION

            // Check if this is a tree URI (directory) or document URI (file)
            val uriToPermission = if (isDirectory()) {
                // For directories, we need to get the tree URI
                val documentId = DocumentsContract.getTreeDocumentId(uri)
                DocumentsContract.buildTreeDocumentUri(authority, documentId)
            } else {
                // For files, use the URI directly
                uri
            }

            FileKit.context.contentResolver.takePersistableUriPermission(uriToPermission, flags)
            val data = androidFile.uri.toString()
            BookmarkData(data.encodeToByteArray())
        }
    }
}

public actual fun PlatformFile.Companion.fromBookmarkData(
    bookmarkData: BookmarkData
): PlatformFile {
    val str = bookmarkData.bytes.decodeToString()
    return when {
        // Content Uri always starts with "content://"
        str.startsWith("content://") -> {
            val uriString = str
            @SuppressLint("UseKtx")
            PlatformFile(Uri.parse(uriString))
        }
        
        // Very rarely used Uri, discouraged and deprecated, may starts with "file://"
        str.startsWith("file://") -> {
            val filePath = str.removePrefix("file://")
            PlatformFile(File(filePath))
        }
        
        // Removes a chance of exception throwing
        else -> {
            val filePath = str
            PlatformFile(File(filePath))
        }
    }
}

[vinceglb]

Thanks @AnsifDev for your suggestion 🙏 I created a PR #404 from your recommendations.