From 753a041a7269b0f15862c9cfe151bff9ae947494 Mon Sep 17 00:00:00 2001 From: oech3 <79379754+oech3@users.noreply.github.com> Date: Thu, 13 Aug 2026 21:28:18 +0900 Subject: [PATCH] base32: simplify loop --- src/uu/base32/src/base_common.rs | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/src/uu/base32/src/base_common.rs b/src/uu/base32/src/base_common.rs index 79f6435eb46..9944dfd22b9 100644 --- a/src/uu/base32/src/base_common.rs +++ b/src/uu/base32/src/base_common.rs @@ -542,14 +542,11 @@ pub mod fast_encode { let mut encoded_buffer = VecDeque::::new(); let mut leftover_buffer = Vec::::with_capacity(encode_in_chunks_of_size); - loop { - let read_buffer = input - .fill_buf() - .map_err(|err| USimpleError::new(1, super::format_read_error(&err)))?; - if read_buffer.is_empty() { - break; - } - + while let read_buffer = input + .fill_buf() + .map_err(|e| USimpleError::new(1, super::format_read_error(&e)))? + && !read_buffer.is_empty() + { let mut consumed = 0; if !leftover_buffer.is_empty() { @@ -809,15 +806,11 @@ pub mod fast_decode { let mut buffer = Vec::with_capacity(decode_in_chunks_of_size); let mut decoded_buffer = Vec::::new(); - loop { - let read_buffer = input - .fill_buf() - .map_err(|err| USimpleError::new(1, super::format_read_error(&err)))?; - let read_len = read_buffer.len(); - if read_len == 0 { - break; - } - + while let read_buffer = input + .fill_buf() + .map_err(|e| USimpleError::new(1, super::format_read_error(&e)))? + && let read_len @ 1.. = read_buffer.len() + { for &byte in read_buffer { if byte == b'\n' || byte == b'\r' { continue;