Skip to content

fix(netlabel): preserve schematicsymbol projection identity for shared supply pins - #4883

Open
ducanh3005 wants to merge 1 commit into
tscircuit:mainfrom
ducanh3005:fix/schematicsymbol-shared-supply-netlabels-3505
Open

ducanh3005 wants to merge 1 commit into
tscircuit:mainfrom
ducanh3005:fix/schematicsymbol-shared-supply-netlabels-3505

Conversation

@ducanh3005

Copy link
Copy Markdown

Summary

  • Updates NetLabel to resolve schematic port positions and facing directions from db.schematic_port when available before layout so coordinate-free
    etlabel attachments to schematicsymbol ports do not throw during computeSchematicPropsTransform.
  • Scopes existing-trace deduplication in NetLabel to the specific target projection port coordinates rather than skipping all projections that share a physical source_port_id, ensuring every shared schematicsymbol supply projection port is marked is_connected: true and receives its own stem/trace connection without generating duplicate fallback rail labels in exposedNets composites.
  • Adds 4 regression tests in ests/repros/repro3505-schematicsymbol-shared-supply-netlabels.test.tsx.

Fixes #3505

@vercel

vercel Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Oct 24, 2026 4:27am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 5a27cdd3 Deployed Oct 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Net labels lose identity across shared schematicsymbol supply projections

1 participant