From 9140c9e2c1763799eb3cd8dd5edf0830bff7f430 Mon Sep 17 00:00:00 2001 From: Tim te Beek Date: Tue, 20 May 2025 21:54:19 +0200 Subject: [PATCH 1/3] Add BookTest --- .../betterassertions/review/BookTest.java | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java diff --git a/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java b/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java new file mode 100644 index 0000000..d5b1a7d --- /dev/null +++ b/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java @@ -0,0 +1,18 @@ +package com.github.timtebeek.betterassertions.review; + +import com.github.timtebeek.betterassertions.Book; +import org.junit.jupiter.api.Test; + +import static org.junit.Assert.assertEquals; + +public class BookTest { + + @Test + public void test() { + Book book = new Book( + "The Great Gatsby", + "F. Scott Fitzgerald", + 1925); + assertEquals("The Great Gatsby", book.getTitle()); + } +} From 6179e95d1177b503b1cb32700e821c6b1fce6126 Mon Sep 17 00:00:00 2001 From: Tim te Beek Date: Tue, 9 Sep 2025 21:47:47 +0200 Subject: [PATCH 2/3] Use non-static import for now --- .../github/timtebeek/betterassertions/review/BookTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java b/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java index d5b1a7d..dff519a 100644 --- a/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java +++ b/src/test/java/com/github/timtebeek/betterassertions/review/BookTest.java @@ -1,10 +1,9 @@ package com.github.timtebeek.betterassertions.review; import com.github.timtebeek.betterassertions.Book; +import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; - public class BookTest { @Test @@ -13,6 +12,7 @@ public void test() { "The Great Gatsby", "F. Scott Fitzgerald", 1925); - assertEquals("The Great Gatsby", book.getTitle()); + + Assertions.assertEquals("The Great Gatsby", book.getTitle()); } } From 733746cc3a154bdd70810f5b127d424a7b2f15a2 Mon Sep 17 00:00:00 2001 From: Tim te Beek Date: Tue, 9 Sep 2025 21:58:56 +0200 Subject: [PATCH 3/3] Use actions/upload-artifact@v4 --- .github/workflows/receive-pr.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/receive-pr.yml b/.github/workflows/receive-pr.yml index 1fae1b3..df87b96 100644 --- a/.github/workflows/receive-pr.yml +++ b/.github/workflows/receive-pr.yml @@ -33,7 +33,7 @@ jobs: # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow - name: Create pr_number.txt run: echo "${{ github.event.number }}" > pr_number.txt - - uses: actions/upload-artifact@v5 + - uses: actions/upload-artifact@v4 with: name: pr_number path: pr_number.txt @@ -51,7 +51,7 @@ jobs: - name: Create patch run: | git diff | tee git-diff.patch - - uses: actions/upload-artifact@v5 + - uses: actions/upload-artifact@v4 with: name: patch - path: git-diff.patch \ No newline at end of file + path: git-diff.patch