Skip to content

fix(release): apply project-specific OCI labels to images for Operator - #4079

Closed
TheDevCodingKen wants to merge 1 commit into
tektoncd:mainfrom
TheDevCodingKen:fix/oci-image-labels
Closed

TheDevCodingKen wants to merge 1 commit into
tektoncd:mainfrom
TheDevCodingKen:fix/oci-image-labels

Conversation

@TheDevCodingKen

Copy link
Copy Markdown
Contributor

Changes

Fixes tektoncd/plumbing#3435

This updates the tekton/build-publish-images-manifests.yaml task to explicitly pass project-specific OCI image labels (url, title, and description) to the ko resolve commands. This prevents the published Operator images from incorrectly inheriting OCI metadata from their base images.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 11, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign savitaashture after the PR has been reviewed.
You can assign the PR to them by writing /assign @savitaashture in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2026
@jkhelil

jkhelil commented Sep 14, 2026

Copy link
Copy Markdown
Member

@TheDevCodingKen how did you raise the PR ? is there a human in the loop

@TheDevCodingKen

TheDevCodingKen commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor Author

@TheDevCodingKen how did you raise the PR ? is there a human in the loop

@jkhelil I'm the human in the loop. I manually made the changes locally based what was merged in the related background section of the main issue.

image

@TheDevCodingKen

Copy link
Copy Markdown
Contributor Author

Pinging @infernus01 and @pramodbindal for approval

@jkhelil

jkhelil commented Sep 17, 2026

Copy link
Copy Markdown
Member

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2026
@jkhelil jkhelil closed this Sep 17, 2026
@jkhelil jkhelil reopened this Sep 17, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.66%. Comparing base (3d8e72a) to head (65a1b5d).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4079      +/-   ##
==========================================
+ Coverage   25.40%   27.66%   +2.26%     
==========================================
  Files         449      477      +28     
  Lines       23477    25469    +1992     
==========================================
+ Hits         5964     7046    +1082     
- Misses      16822    17699     +877     
- Partials      691      724      +33     
Flag Coverage Δ
unit-tests 27.66% <ø> (+2.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkhelil jkhelil closed this Sep 28, 2026
@jkhelil

jkhelil commented Sep 28, 2026

Copy link
Copy Markdown
Member

Thanks change looks aligned with plumbing#3435, but we don’t merge agent-style PRs without a maintainer-owned follow-up.
I will accept a re-open from someone who can own release validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize OCI image labels across Tekton release images

3 participants