chore(wallet/sdk): minor cleanup - #1627

Walkthrough

This PR consolidates the wallet storage abstraction by restructuring a monolithic storage module into separate error, reader, and writer components, fixes the typo CommitableStore → CommittableStore across the codebase, refactors LocksApi with trait-bounded impl blocks, removes context management methods from WalletSdk, and updates the accounts API to use transactional helpers.

Changes

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant SDK as WalletSdk
    participant Store as ReadableWalletStore/<br/>WriteableWalletStore
    participant Tx as Transaction

    rect rgb(200, 230, 255)
    Note over Client,Tx: Read Flow (with_read_tx)
    Client->>SDK: api.with_read_tx(closure)
    SDK->>Store: create_read_tx()
    Store->>Tx: create transaction
    Tx-->>SDK: ReadTransaction
    SDK->>Tx: closure(&mut tx)
    Tx->>Tx: read operations
    Tx-->>SDK: Result<R>
    SDK-->>Client: Result<R>
    end

    rect rgb(230, 200, 255)
    Note over Client,Tx: Write Flow (with_write_tx)
    Client->>SDK: api.with_write_tx(closure)
    SDK->>Store: create_write_tx()
    Store->>Tx: create transaction
    Tx-->>SDK: WriteTransaction
    SDK->>Tx: closure(&mut tx)
    Tx->>Tx: write operations
    alt Success
        Tx->>Tx: commit()
        Tx-->>SDK: Ok(Result<R>)
    else Error in Closure
        Tx->>Tx: rollback()
        Tx-->>SDK: Err(WalletStorageError)
    end
    SDK-->>Client: Result<R>
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Storage module restructuring: Verify that trait definitions, blanket implementations, and with_read_tx/with_write_tx logic are correctly implemented across error.rs, mod.rs, reader.rs, and writer.rs files
• LocksApi trait-bounded impl blocks: Ensure all methods are correctly placed in the appropriate impl block (WriteableWalletStore vs. ReadableWalletStore vs. unbounded) and that trait bounds are properly enforced
• Removed public APIs: Confirm that removal of context management methods from WalletSdk doesn't break existing callers and validate the migration path to with_read_tx/with_write_tx patterns
• Repetitive import updates: While most are straightforward spelling corrections, verify that all CommitableStore → CommittableStore renames are complete and consistent across all files
• Transaction logic update in accounts.rs: Validate that the closure-based pattern in count() correctly replaces the previous transaction handling

Possibly related PRs

• PR fix: timeout fund locks after a while #1621: Restructures wallet storage abstraction with CommittableStore trait and modular storage components (error, reader, writer modules) — directly related at code level
• PR feat(wallet): add stealth_utxos.list rpc call #1576: Extends WalletStoreReader trait with stealth_outputs_get_many and related reader methods — shares storage reader API modifications
• PR fix(wallet)!: support multiple vault locks, handle partial commit case #1611: Modifies storage abstraction and LocksApi trait implementations — overlapping changes to storage traits and lock handling

Suggested labels

P-acks_required, P-reviews_required

Suggested reviewers

• stringhandler

Poem

🐰 A typo fixed, storage neat,
From one big file to modules sweet,
With read and write txns flow,
Through branching bounds, the traits now glow,
Context gone, but closures greet!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}