fix connection in case device node is online or down

Author: Hamdy-khader

simplyblock_core/controllers/health_controller.py

@@ -408,7 +408,9 @@ def _check_node_lvstore(
                                 if result['Kind'] == "Device":
                                     if result['Found Status']:
                                         dev = db_controller.get_storage_device_by_id(result['UUID'])
-                                        if dev.status == NVMeDevice.STATUS_ONLINE:
+                                        dev_node = db_controller.get_storage_node_by_id(dev.node_id)
+                                        if dev.status == NVMeDevice.STATUS_ONLINE and dev_node.status in [
+                                            StorageNode.STATUS_ONLINE, StorageNode.STATUS_DOWN]:
                                             try:
                                                 remote_bdev = storage_node_ops.connect_device(
                                                     f"remote_{dev.alceml_bdev}", dev, node,

simplyblock_core/services/health_check_service.py

@@ -139,7 +139,7 @@ def check_node(snode, logger):
         for remote_device in snode.remote_devices:
             org_dev = db.get_storage_device_by_id(remote_device.get_id())
             org_node = db.get_storage_node_by_id(remote_device.node_id)
-            if org_dev.status == NVMeDevice.STATUS_ONLINE and org_node.status == StorageNode.STATUS_ONLINE:
+            if org_dev.status == NVMeDevice.STATUS_ONLINE and org_node.status in [StorageNode.STATUS_ONLINE, StorageNode.STATUS_DOWN]:
                 if health_controller.check_bdev(remote_device.remote_bdev, bdev_names=node_bdev_names):
                     connected_devices.append(remote_device.get_id())
                     continue