Show 'filter hides N words' in the status bar for a filtered word list, and show *** for a missing gloss or analysis instead of ? or a dash.

Co-Authored-By: Claude Sonnet <noreply@anthropic.com>

Author: johnml1135

src/SIL.Motif.App/MotifAppStrings.cs

@@ -242,6 +242,7 @@ public static class MotifAppStrings
     public static string OpenWarningsAccessibleName => Text("MotifApp.OpenWarningsAccessibleName");
 
     public static string StatusChangesPattern => Text("MotifApp.StatusChangesPattern");
+    public static string StatusFilterHidesPattern => Text("MotifApp.StatusFilterHidesPattern");
 
     public static string StatusWarningsPattern => Text("MotifApp.StatusWarningsPattern");
 

src/SIL.Motif.App/MotifAppStrings.resx

@@ -172,6 +172,10 @@
     <value>{0, plural, one {# change not applied yet} other {# changes not applied yet}}</value>
     <comment>Plural pattern: the status bar changes sentence; # is the count.</comment>
   </data>
+  <data name="MotifApp.StatusFilterHidesPattern" xml:space="preserve">
+    <value>{0, plural, one {filter hides # word} other {filter hides # words}}</value>
+    <comment>Plural pattern: status bar note on the Texts page saying how many words the active word-list filter hides; # is the count.</comment>
+  </data>
   <data name="MotifApp.StatusWarningsPattern" xml:space="preserve">
     <value>{0, plural, one {# warning} other {# warnings}}</value>
     <comment>Plural pattern: the status bar warnings sentence; # is the count.</comment>

src/SIL.Motif.App/ViewModels/AssessWordsViewModel.cs

@@ -416,7 +416,7 @@ public ParserReadingViewModel(int number, ParserReading reading, string? grade)
         StoredAnalysisId = reading.StoredAnalysisId;
         StoredAnalysisOpinion = reading.StoredAnalysisOpinion;
         Text = string.Join(" + ", Morphs.Select(morph => morph.Form)) + " = " +
-               string.Join(" + ", Morphs.Select(morph => morph.Gloss.Length == 0 ? "?" : morph.Gloss));
+               string.Join(" + ", Morphs.Select(morph => morph.Gloss.Length == 0 ? MissingValue.Marker : morph.Gloss));
         Grade = grade;
         IsApproved = grade == ReadingGrade.Approved;
         IsDisapproved = grade == ReadingGrade.Disapproved;
@@ -469,7 +469,7 @@ public ParserReadingViewModel(int number, ParserReading reading, string? grade)
 public sealed class ParserReadingMorphViewModel
 {
     private const string UnknownForm = "unknown morpheme";
-    private readonly string _glossPlaceholder = "?";
+    private readonly string _glossPlaceholder = MissingValue.Marker;
     private readonly string? _entry;
     private readonly string _toolName;
 
@@ -501,13 +501,13 @@ private ParserReadingMorphViewModel(ParserReadingMorph morph, string form, strin
 
     /// <summary>
     /// A morpheme from a parser trace, which may not know a morpheme's form or gloss: an unnamed one reads
-    /// "unknown morpheme" and a missing gloss a dash, never a bare question mark.
+    /// "unknown morpheme" and a missing gloss three stars, never a bare question mark.
     /// </summary>
     public static ParserReadingMorphViewModel ForTrace(ParserReadingMorph morph)
     {
         ArgumentNullException.ThrowIfNull(morph);
         var form = string.IsNullOrWhiteSpace(morph.Form) || morph.Form.Trim() == "?" ? UnknownForm : morph.Form;
-        return new ParserReadingMorphViewModel(morph, form, "—");
+        return new ParserReadingMorphViewModel(morph, form, MissingValue.Marker);
     }
 
     public string Form { get; }

src/SIL.Motif.App/ViewModels/AssessmentRowFacts.cs

@@ -55,11 +55,11 @@ private string ReadingText(int index)
     {
         if (Source.Readings is { } readings)
             return index < readings.Count ? string.Join(" + ", readings[index].Morphs.Select(morph => morph.Form))
-                + " = " + string.Join(" + ", readings[index].Morphs.Select(morph => morph.Gloss.Length == 0 ? "?" : morph.Gloss))
+                + " = " + string.Join(" + ", readings[index].Morphs.Select(morph => morph.Gloss.Length == 0 ? MissingValue.Marker : morph.Gloss))
                 : "Unresolved";
         var morphs = Source.Morphology!.Analyses[index].Morphs;
         return string.Join(" + ", morphs.Select(morph => morph.GuessedString ?? "?")) + " = " +
-            string.Join(" + ", morphs.Select(_ => "?"));
+            string.Join(" + ", morphs.Select(_ => MissingValue.Marker));
     }
 }
 

src/SIL.Motif.App/ViewModels/DifferenceViewModel.cs

@@ -347,10 +347,10 @@ public WordInteractionState PresentationState
     private static string Describe(AssessmentRowFacts row)
     {
         var readings = row.Source.Readings?.Select(reading => string.Join(" + ", reading.Morphs.Select(morph => morph.Form))
-            + " = " + string.Join(" + ", reading.Morphs.Select(morph => morph.Gloss.Length == 0 ? "?" : morph.Gloss)))
+            + " = " + string.Join(" + ", reading.Morphs.Select(morph => morph.Gloss.Length == 0 ? MissingValue.Marker : morph.Gloss)))
             ?? row.Source.Morphology?.Analyses.Select(analysis =>
                 string.Join(" + ", analysis.Morphs.Select(morph => morph.GuessedString ?? "?")) + " = " +
-                string.Join(" + ", analysis.Morphs.Select(_ => "?"))) ?? [];
+                string.Join(" + ", analysis.Morphs.Select(_ => MissingValue.Marker))) ?? [];
         var text = string.Join(" | ", readings);
         return text.Length == 0 ? row.Result : $"{row.Result}: {text}";
     }

src/SIL.Motif.App/ViewModels/KeyboardOpinionShortcuts.cs

@@ -7,7 +7,7 @@ namespace SIL.Motif.App.ViewModels;
 internal sealed record KeyboardStoredAnalysis(string Id, string Opinion, IReadOnlyList<ParserReadingMorph> Morphs)
 {
     public string DisplayReading => string.Join(" ", Morphs.Select(morph =>
-        $"{morph.Form} = {(string.IsNullOrWhiteSpace(morph.Gloss) ? "?" : morph.Gloss)}"));
+        $"{morph.Form} = {(string.IsNullOrWhiteSpace(morph.Gloss) ? MissingValue.Marker : morph.Gloss)}"));
 }
 
 internal sealed record PendingStoredOpinionChange(

src/SIL.Motif.App/ViewModels/MissingValue.cs

@@ -0,0 +1,11 @@
+namespace SIL.Motif.App.ViewModels;
+
+/// <summary>
+/// The FieldWorks marker for a gloss or analysis that is missing. Empty values elsewhere stay empty: no placeholder
+/// characters stand in for them.
+/// </summary>
+public static class MissingValue
+{
+    /// <summary>Shown in place of a missing gloss or analysis.</summary>
+    public const string Marker = "***";
+}

src/SIL.Motif.App/ViewModels/ResultsTokenViewModel.cs

@@ -867,9 +867,9 @@ private void SyncPresentationState(Func<WordInteractionState, WordInteractionSta
     }
 
     // Forms already carry their own hyphens ("a-", "-a"), so they join as written; glosses join with one.
-    private static string ReadingText(ParserReading? reading) => reading is null ? "?"
+    private static string ReadingText(ParserReading? reading) => reading is null ? MissingValue.Marker
         : JoinForms(reading.Morphs.Select(morph => morph.Form)) + " ‘" +
-          string.Join("-", reading.Morphs.Select(morph => morph.Gloss.Length == 0 ? "?" : morph.Gloss)) + "’";
+          string.Join("-", reading.Morphs.Select(morph => morph.Gloss.Length == 0 ? MissingValue.Marker : morph.Gloss)) + "’";
 
     private static string JoinForms(IEnumerable<string> forms)
     {

src/SIL.Motif.App/ViewModels/TextWordsViewModel.Selection.cs

@@ -58,6 +58,8 @@ private void ApplySummaryFilter()
         if (!string.IsNullOrWhiteSpace(SearchText))
             matches = matches.Where(word => word.Key.Form.Contains(SearchText.Trim(), StringComparison.CurrentCultureIgnoreCase));
         var ordered = matches.OrderByDescending(word => word.OccurrenceCount).ToArray();
+        _hiddenByFilter = (_selectionReads.Summary?.Words.Count ?? 0) - ordered.Length;
+        OnPropertyChanged(nameof(FilterHidesText));
         var generation = _rowsGeneration;
         Rows = new LazyProjectionList<SelectionWordSummary, TextWordRowViewModel>(ordered,
             GetSummaryRow, row => row.Summary!, () => generation == _rowsGeneration && _acceptLoads);

src/SIL.Motif.App/ViewModels/TextWordsViewModel.cs

@@ -252,6 +252,12 @@ public Action<IReadOnlyList<string>>? HandOff
             : "No words to test yet"
         : $"{WordCount:N0} word{(WordCount == 1 ? string.Empty : "s")} · {OccurrenceCount:N0} place{(OccurrenceCount == 1 ? string.Empty : "s")}";
 
+    /// <summary>Status-bar text naming how many words the active filter hides; empty when none are hidden.</summary>
+    public string FilterHidesText => _hiddenByFilter == 0 ? string.Empty
+        : PluralText.Format(MotifAppStrings.StatusFilterHidesPattern, _hiddenByFilter);
+
+    private int _hiddenByFilter;
+
     public int AllCount => _selectionReads.Summary?.WordRowCount ?? 0;
     public int ApprovedFilterCount => CountStanding(ProjectStanding.Approved);
     public int CandidateFilterCount => CountStanding(ProjectStanding.Candidate);
@@ -362,6 +368,7 @@ private void RaiseCounts()
     {
         OnPropertyChanged(nameof(WordCount));
         OnPropertyChanged(nameof(SummaryText));
+        OnPropertyChanged(nameof(FilterHidesText));
         OnPropertyChanged(nameof(AllCount));
         OnPropertyChanged(nameof(ApprovedFilterCount));
         OnPropertyChanged(nameof(CandidateFilterCount));
@@ -861,7 +868,7 @@ public ProjectAnalysisViewModel(ProjectAnalysis analysis)
     {
         ArgumentNullException.ThrowIfNull(analysis);
         Morphs = analysis.Morphs.Select(morph => new ParserReadingMorphViewModel(morph)).ToArray();
-        Gloss = string.Join(" ", Morphs.Select(morph => morph.Gloss.Length == 0 ? "?" : morph.Gloss));
+        Gloss = string.Join(" ", Morphs.Select(morph => morph.Gloss.Length == 0 ? MissingValue.Marker : morph.Gloss));
     }
 
     public IReadOnlyList<ParserReadingMorphViewModel> Morphs { get; }