Skip to content

Commit e2c333d

Browse files
bdchathamdevin-ai-integration[bot]claude
authored
ci: move sei-chain onto the seidroid review workflow, retire ai-review (#4372)
sei-chain still reviews through the legacy `ai-review.yml` caller (uci v0.0.21). sei-load, sei-k8s-controller and platform have already moved to seidroid, and both systems post under the same bot identity, so only one of them should be the automatic reviewer. This adds `.github/workflows/seidroid.yml`, which calls uci `seidroid-review.yml` pinned to `ad9635ae` (v0.0.24). It reviews on PR open, ready, sync and reopen, and on `@seidroid review` in a top-level comment, an inline comment or a review body. `@seidroid review close` in any of those same three places tears the session down. The close job uses the same `contains` match the review job uses to skip, so no close command falls between the two jobs, and uci's parser applies the line-anchored grammar. Closing the PR reclaims the session. `ai-review.yml` is deleted. Two settings carry over from it: `allowed-team: sei-protocol/sei-core` and `allowed-bots: ["seidroid[bot]"]`, which keeps review on backport PRs. `guidelines-file` is left unset, so the reviewer still reads `REVIEW.md`, and `publish-ai-review-check` stays at its default, so a branch rule that names `AI Review` still gets that check. Unlike the other repos, `approve-on-success` is explicitly `false`. In sei-chain an approval from the bot could satisfy a required-review rule, and turning that on is a policy call. A clean review therefore posts no approval, while a blocking one still requests changes. The workflow needs the repo secret `OMNIGENT_MACHINE_CLIENT_SECRET` and the org secrets `PLATFORM_CODE_AGENT_APP_ID`/`_PK`. All three are now visible to sei-chain, and this PR's own seidroid runs completed a review with both the codex scout and the Claude reviewer. Link to Devin session: https://app.devin.ai/sessions/1541fbafefb74e37b35352812dd520c0 Open in Devin Desktop: https://app.devin.ai/desktop/session/1541fbafefb74e37b35352812dd520c0?variant=devin Requested by: @bdchatham --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent b34bf7f commit e2c333d

2 files changed

Lines changed: 82 additions & 25 deletions

File tree

‎.github/workflows/ai-review.yml‎

Lines changed: 0 additions & 25 deletions
This file was deleted.

‎.github/workflows/seidroid.yml‎

Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
name: seidroid review
2+
3+
on:
4+
issue_comment:
5+
types: [created]
6+
pull_request_review_comment:
7+
types: [created]
8+
pull_request_review:
9+
types: [submitted]
10+
pull_request:
11+
types: [opened, ready_for_review, synchronize, reopened, closed]
12+
13+
permissions: {}
14+
15+
jobs:
16+
seidroid-review:
17+
if: >-
18+
(github.event_name == 'pull_request' &&
19+
github.event.action != 'closed') ||
20+
(((github.event_name == 'issue_comment' &&
21+
github.event.issue.pull_request != null) ||
22+
github.event_name == 'pull_request_review_comment' ||
23+
github.event_name == 'pull_request_review') &&
24+
contains(github.event.comment.body || github.event.review.body,
25+
'@seidroid review') &&
26+
!contains(github.event.comment.body || github.event.review.body,
27+
'@seidroid review close'))
28+
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@ad9635aeeaec226785dd1756f666cffc538981f8 # v0.0.24
29+
permissions:
30+
contents: read
31+
pull-requests: write
32+
checks: write
33+
issues: write
34+
secrets:
35+
OMNIGENT_MACHINE_CLIENT_SECRET: ${{ secrets.OMNIGENT_MACHINE_CLIENT_SECRET }}
36+
SEIDROID_APP_ID: ${{ secrets.PLATFORM_CODE_AGENT_APP_ID }}
37+
SEIDROID_APP_PRIVATE_KEY: ${{ secrets.PLATFORM_CODE_AGENT_APP_PK }}
38+
with:
39+
mode: review
40+
allowed-team: 'sei-protocol/sei-core'
41+
allowed-bots: '["seidroid[bot]"]'
42+
approve-on-success: false
43+
44+
# Anchored, unlike the review job's `contains`. A comment that quotes the
45+
# teardown command beside a real `@seidroid review` line would otherwise route
46+
# here, and uci v0.0.24 admits it on the review line without checking it
47+
# against `mode`, so the session would be destroyed. Anchoring only this,
48+
# destructive, job keeps such a comment from destroying anything. PLT-1182
49+
# fixes the grammar once in uci, which can compare the parsed line to `mode`.
50+
seidroid-review-close:
51+
if: >-
52+
github.event_name == 'issue_comment' &&
53+
github.event.issue.pull_request != null &&
54+
startsWith(github.event.comment.body, '@seidroid review close')
55+
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@ad9635aeeaec226785dd1756f666cffc538981f8 # v0.0.24
56+
permissions:
57+
contents: read
58+
pull-requests: write
59+
checks: write
60+
issues: write
61+
secrets:
62+
OMNIGENT_MACHINE_CLIENT_SECRET: ${{ secrets.OMNIGENT_MACHINE_CLIENT_SECRET }}
63+
SEIDROID_APP_ID: ${{ secrets.PLATFORM_CODE_AGENT_APP_ID }}
64+
SEIDROID_APP_PRIVATE_KEY: ${{ secrets.PLATFORM_CODE_AGENT_APP_PK }}
65+
with:
66+
mode: close
67+
allowed-team: 'sei-protocol/sei-core'
68+
69+
seidroid-review-reclaim:
70+
if: github.event_name == 'pull_request' && github.event.action == 'closed'
71+
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@ad9635aeeaec226785dd1756f666cffc538981f8 # v0.0.24
72+
permissions:
73+
contents: read
74+
pull-requests: write
75+
checks: write
76+
issues: write
77+
secrets:
78+
OMNIGENT_MACHINE_CLIENT_SECRET: ${{ secrets.OMNIGENT_MACHINE_CLIENT_SECRET }}
79+
SEIDROID_APP_ID: ${{ secrets.PLATFORM_CODE_AGENT_APP_ID }}
80+
SEIDROID_APP_PRIVATE_KEY: ${{ secrets.PLATFORM_CODE_AGENT_APP_PK }}
81+
with:
82+
mode: close

0 commit comments

Comments
 (0)