Skip to content

Commit e29c181

Browse files
authored
Remove ConfigManager and the in-tree config registry (#4586)
`seid` has carried two configuration managers since the PLT-775 work: the legacy one, which forwards to `server.InterceptConfigsPreRunHandler`, and a v2 `SeiConfigManager` selected by `SEI_CONFIG_MANAGER=v2` that reads a unified `sei.toml`. Nothing sets that variable and nothing writes a `sei.toml`, including the Kubernetes controller, whose sidecar writes `config.toml` and `app.toml` through sei-config. Every node therefore runs the legacy path, and the v2 manager, the `config/` registry that only it reads, the section registrations in each module and the unreleased `seid config check` are dead code. This removes `cmd/seid/cmd/configmanager`, the whole `config/` tree (`registry`, `seitoml`, `appopts`, `tendermintbase`, `cosmosbase`), the section registrations and their tests, and the tests that only exercised v2. `PersistentPreRunE` now calls `server.InterceptConfigsPreRunHandler` directly. Two live symbols that sat in registration code are kept: `wasm.GeneratedQueryGasLimit` moves to `sei-wasmd/x/wasm/alias.go`, and `NodeMode.IsFullnodeType` compares against `NodeModeFull` and `NodeModeArchive` instead of calling the registry. The legacy characterization tests stay and now call the handler directly. `github.com/sei-protocol/sei-config` drops out of `go.mod`. There is no consensus, state or config-file change. The only visible differences are that `SEI_CONFIG_MANAGER` is ignored (an invalid value used to abort startup) and `seid config check` is gone, which was never in a release tag. Validated with `make lint` and tests for `cmd/seid/cmd`, `app`, `app/params`, wasm, `testutil/configtest` and every package whose registration was removed.
1 parent 44ee2d3 commit e29c181

70 files changed

Lines changed: 27 additions & 17499 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎admin/register.go‎

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎admin/register_test.go‎

Lines changed: 0 additions & 44 deletions
This file was deleted.

‎app/config_register.go‎

Lines changed: 0 additions & 217 deletions
This file was deleted.

‎app/config_register_agreement_test.go‎

Lines changed: 0 additions & 78 deletions
This file was deleted.

0 commit comments

Comments
 (0)