You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d27422c
Browse filesBrowse the repository at this point in the historyBrowse files
Drop gRPC names from the query service router and handlers (#4689)
The Cosmos gRPC and gRPC-Web servers were removed in #4570, but the code
that serves the protobuf `Query` services over ABCI query, grpc-gateway
REST and the precompiles still carries gRPC names, which reads as if a
gRPC server were still in play.
This renames those leftovers without changing behavior.
`baseapp.GRPCQueryRouter`, `NewGRPCQueryRouter`, `GRPCQueryHandler`,
`BaseApp.GRPCQueryRouter()` and `handleQueryGRPC` become
`QueryServiceRouter`, `NewQueryServiceRouter`, `QueryServiceHandler`,
`BaseApp.QueryServiceRouter()` and `handleQueryService`; the
`AppModuleBasic` method `RegisterGRPCGatewayRoutes` and
`api.Server.GRPCGatewayRouter` become `RegisterGatewayRoutes` and
`GatewayRouter`; and `query.WrapGRPCError` becomes
`query.WrapQueryError`. Files follow: `grpc_query*.go` becomes
`query_server*.go` in keepers, `gateway*_test.go` under `client/rest`
and `query_conn*.go` in `client`, `baseapp/grpcrouter*.go` becomes
`query_service_router*.go` (absorbing `grpcserver.go`), and
`grpc_error*.go` becomes `query_error*.go`.
The `google.golang.org/grpc` `codes`/`status` errors and the generated
service code stay, since ABCI query responses and grpc-gateway still use
them. This is not app-hash breaking, but it renames exported sei-cosmos
APIs and module-interface methods, so it is deliberately not backported.
Validated with `go build ./...`, `go vet ./...` and the tests of every
touched package.
0 commit comments