Repository navigation
Commit 6e2c783
authored
Log a pinned node's skipped migration kick-off once per batch size (#4408)
`app/abci.go` calls `rootmulti.Store.SetMigrationBatchSize` with
`NumKeysToMigratePerBlock` on every block. On a node pinned to
`memiavl_only` (a memIAVL reserve), each call with a positive batch size
logs the "skipping migration kick-off" ERROR, so once governance raises
the rate a reserve logs it every block for the rest of its life: about
8.2k lines an hour per arctic-1 reserve pod. That buries anything else
at ERROR and makes the line useless as a signal.
The skip is now logged once per batch size. `Store` remembers the batch
size it last logged a skip for, logs again only when governance changes
the value, and forgets it when the rate goes back to 0, so raising it
again logs again. A restart logs once on the first block. The same
applies to the INFO line for an SC store that does not expose a
configured write mode. Nothing else changes: the kick-off decision and
the write mode are untouched, so this is not app-hash-breaking.
Covered by
`TestRootMultiAutoKickoff_FixedMemiavlOnlySkipLoggedOncePerBatchSize`,
which counts log records across repeated, changed and reset batch sizes;
the existing rootmulti tests pass.1 parent 792ff53 commit 6e2c783
2 files changed
Lines changed: 61 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
4 | 7 | | |
5 | 8 | | |
6 | 9 | | |
| |||
139 | 142 | | |
140 | 143 | | |
141 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
142 | 182 | | |
143 | 183 | | |
144 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
71 | 75 | | |
72 | 76 | | |
73 | 77 | | |
| |||
811 | 815 | | |
812 | 816 | | |
813 | 817 | | |
| 818 | + | |
814 | 819 | | |
815 | 820 | | |
816 | 821 | | |
| |||
825 | 830 | | |
826 | 831 | | |
827 | 832 | | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
828 | 836 | | |
829 | 837 | | |
830 | 838 | | |
831 | 839 | | |
832 | 840 | | |
833 | 841 | | |
834 | 842 | | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
835 | 846 | | |
836 | 847 | | |
837 | 848 | | |
| |||
847 | 858 | | |
848 | 859 | | |
849 | 860 | | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
850 | 871 | | |
851 | 872 | | |
852 | 873 | | |
| |||
0 commit comments