Repository navigation
Commit 5f5562f
staking: branch precompile views and validate redelegations filters (#4527)
This PR addresses 2 things associated with staking precompile.
- The staking precompile (which serves Cosmos module queries) runs it's
view methods on live EVM context instead of a cached context. While no
methods update state (`pool` does but not on a live chain), a method
added in future isn't prevented from writing to the EVM context. Hence,
this PR uses a temporary state (like other precompiles) so that queries
can't persist from a view or static call.
`PrecompileExecutor.IsTransaction` now lists the ten state-changing
staking methods, and `Execute` runs every other method on a branched
context, matching the sibling precompiles. `TestIsTransactionMatchesABI`
ties that list to the ABI's `stateMutability`, so a method added later
cannot be misclassified without failing CI. `
- `redelegations` now accepts only the filter combinations the staking
module can answer: delegator, source validator and destination validator
together, source validator alone, or delegator alone. Any other
combination reverts with a clear error, and `Staking.sol` now documents
the supported combinations. Supporting the remaining combinations would
need new query paths and would change gRPC/REST answers, so it is left
for a follow-up.
This is state-machine breaking change, so this must ship only in the
v6.8 coordinated upgrade and must not be backported to `release/v6.7`.
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent c719251 commit 5f5562f
4 files changed
Lines changed: 164 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
289 | 289 | | |
290 | 290 | | |
291 | 291 | | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
296 | 297 | | |
297 | 298 | | |
298 | 299 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
174 | 186 | | |
175 | 187 | | |
176 | 188 | | |
177 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
178 | 196 | | |
179 | 197 | | |
180 | 198 | | |
| |||
1295 | 1313 | | |
1296 | 1314 | | |
1297 | 1315 | | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
1298 | 1319 | | |
1299 | 1320 | | |
1300 | 1321 | | |
| |||
1341 | 1362 | | |
1342 | 1363 | | |
1343 | 1364 | | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
| 1373 | + | |
| 1374 | + | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
1344 | 1379 | | |
1345 | 1380 | | |
1346 | 1381 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
1545 | 1546 | | |
1546 | 1547 | | |
1547 | 1548 | | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
1548 | 1603 | | |
1549 | 1604 | | |
1550 | 1605 | | |
| |||
2601 | 2656 | | |
2602 | 2657 | | |
2603 | 2658 | | |
| 2659 | + | |
| 2660 | + | |
| 2661 | + | |
| 2662 | + | |
| 2663 | + | |
| 2664 | + | |
| 2665 | + | |
| 2666 | + | |
| 2667 | + | |
| 2668 | + | |
| 2669 | + | |
| 2670 | + | |
| 2671 | + | |
| 2672 | + | |
| 2673 | + | |
| 2674 | + | |
| 2675 | + | |
| 2676 | + | |
| 2677 | + | |
| 2678 | + | |
| 2679 | + | |
| 2680 | + | |
| 2681 | + | |
| 2682 | + | |
| 2683 | + | |
| 2684 | + | |
| 2685 | + | |
| 2686 | + | |
| 2687 | + | |
| 2688 | + | |
| 2689 | + | |
| 2690 | + | |
| 2691 | + | |
| 2692 | + | |
0 commit comments