Repository navigation
Commit 415e691
authored
Remove the unused app/benchmark harness and benchmark scripts (#4673)
`app/benchmark` is an in-node load generator that only runs in a `seid`
built with the `benchmark` tag (`make install-bench`). It builds
synthetic blocks and hands them out on `Manager.ProposalChannel`, and
`benchmark/` holds the shell scripts and scenario JSON that drive it. On
main nothing outside its own test reads that channel, so even a tagged
build generates blocks that are never proposed. Nothing builds or runs
it either: no CI workflow, Makefile caller, image or test references
either directory. External RPC load is generated by sei-load, and
in-process executor ceilings are measured with
`giga/evmonly/cmd/evmonly-loadtest`, which uses neither. It is also the
last thing holding sei-chain's sei-load pin at v0.0.1, because it
imports generator APIs that sei-load has since removed.
This removes `app/benchmark`, `benchmark/`, the `App` hooks that fed it
(`InitBenchmark`, the block-timing and receipt hooks in
`ProcessProposalHandler`/`FinalizeBlocker`, `RecordBenchmarkCommitTime`
in `Commit`), the `benchmarkEnabled` build-tag constants in `app` and
`sei-tendermint/types` (the latter was never read), the `install-bench`
target and the root `AGENTS.md` pointer to the deleted guide.
`mock_balances` and `make install-mock-balances` stay, since the nightly
images build with them.
There is no consensus or state impact. In a default build
`benchmarkEnabled` was false, so the manager was nil and every removed
hook already returned without doing anything. `go build ./...`, `go
build -tags mock_balances ./cmd/seid`, `make fmtcheck`, golangci-lint on
the touched packages and the `app` tests pass. `go mod tidy` changes
nothing, so bumping the sei-load pin is a separate PR.1 parent 612b4a4 commit 415e691
24 files changed
Lines changed: 0 additions & 2493 deletions
File tree
- app
- benchmark
- benchmark
- scenarios
- sei-tendermint/types
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | 92 | | |
94 | 93 | | |
95 | 94 | | |
| |||
101 | 100 | | |
102 | 101 | | |
103 | 102 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | 103 | | |
108 | 104 | | |
109 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
307 | 306 | | |
308 | 307 | | |
309 | 308 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | 98 | | |
100 | 99 | | |
101 | 100 | | |
| |||
131 | 130 | | |
132 | 131 | | |
133 | 132 | | |
134 | | - | |
135 | 133 | | |
136 | 134 | | |
137 | 135 | | |
| |||
430 | 428 | | |
431 | 429 | | |
432 | 430 | | |
433 | | - | |
434 | | - | |
435 | 431 | | |
436 | 432 | | |
437 | 433 | | |
| |||
891 | 887 | | |
892 | 888 | | |
893 | 889 | | |
894 | | - | |
895 | | - | |
896 | | - | |
897 | | - | |
898 | | - | |
899 | | - | |
900 | 890 | | |
901 | 891 | | |
902 | 892 | | |
| |||
1127 | 1117 | | |
1128 | 1118 | | |
1129 | 1119 | | |
1130 | | - | |
1131 | | - | |
1132 | | - | |
1133 | 1120 | | |
1134 | 1121 | | |
1135 | 1122 | | |
| |||
1231 | 1218 | | |
1232 | 1219 | | |
1233 | 1220 | | |
1234 | | - | |
1235 | | - | |
1236 | | - | |
1237 | | - | |
1238 | 1221 | | |
1239 | 1222 | | |
1240 | 1223 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments