Skip to content

Commit 40a8d57

Browse files
authored
Remove the unused sei-cosmos, sei-tendermint and sei-wasmd Makefiles (#4620)
The sei-cosmos, sei-tendermint and sei-wasmd Makefiles are upstream leftovers that nothing invokes: no workflow, root Makefile target, script or Dockerfile calls them, and many of their targets point at directories, scripts and commands that no longer exist (`docs/`, `DOCKER/`, `cmd/wasmd`, `scripts/protocgen.sh`, dredd without a `dredd.yml`). The root Makefile and root `buf.gen.yaml` are what actually build seid and generate the protobufs for all three modules. This deletes those three Makefiles, `sei-tendermint/test/Makefile` and `sei-cosmos/ics23/Makefile`, along with the files only they used: `sei-tendermint/cmd/contract_tests` (which drops the `snikch/goodman` dependency), `sei-tendermint/test/docker`, `test_cover.sh`, the old tendermint `dist.sh` and `build.sh`, `sei-wasmd/scripts` and `sei-wasmd/contrib/devtools`. The metricsgen golden-file failure message and the tendermint proto, ABCI and test READMEs now point at `go generate` on the metricsgen testdata, `scripts/protoc.sh` and `go test` instead of the removed targets. The `sei-wasmvm` and `sei-db` Makefiles stay, as CI and `gigasim.sh` use them, and the `go:generate` directives for mockery and metricsgen are untouched. There is no runtime, state or consensus impact. `go build ./...`, the metricsgen tests and `make fmtcheck` pass.
1 parent 31ff655 commit 40a8d57

23 files changed

Lines changed: 5 additions & 1329 deletions

File tree

‎go.mod‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ require (
7373
github.com/sei-protocol/sei-tm-db v0.0.5
7474
github.com/sei-protocol/seilog v0.0.3
7575
github.com/shirou/gopsutil/v3 v3.23.2
76-
github.com/snikch/goodman v0.0.0-20171125024755-10e37e294daa
7776
github.com/spf13/cast v1.10.0
7877
github.com/spf13/cobra v1.10.2
7978
github.com/spf13/pflag v1.0.10

‎go.sum‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1303,8 +1303,6 @@ github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPx
13031303
github.com/sirupsen/logrus v1.4.2/go.mod h1:tLMulIdttU9McNUspp0xgXVQah82FyeX6MwdIuYE2rE=
13041304
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
13051305
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
1306-
github.com/snikch/goodman v0.0.0-20171125024755-10e37e294daa h1:YJfZp12Z3AFhSBeXOlv4BO55RMwPn2NoQeDsrdWnBtY=
1307-
github.com/snikch/goodman v0.0.0-20171125024755-10e37e294daa/go.mod h1:oJyF+mSPHbB5mVY2iO9KV3pTt/QbIkGaO8gQ2WrDbP4=
13081306
github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 h1:+jumHNA0Wrelhe64i8F6HNlS8pkoyMv5sreGx2Ry5Rw=
13091307
github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8/go.mod h1:3n1Cwaq1E1/1lhQhtRK2ts/ZwZEhjcQeJQ1RuC6Q/8U=
13101308
github.com/spaolacci/murmur3 v0.0.0-20180118202830-f09979ecbc72/go.mod h1:JwIasOWyU6f++ZhiEuf87xNszmSA2myDM2Kzu9HwQUA=

‎sei-cosmos/Makefile‎

Lines changed: 0 additions & 386 deletions
This file was deleted.

‎sei-cosmos/ics23/Makefile‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎sei-tendermint/Makefile‎

Lines changed: 0 additions & 283 deletions
This file was deleted.

‎sei-tendermint/abci/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ A detailed description of the ABCI methods and message types is contained in:
2727
To compile the protobuf file, run (from the root of the repo):
2828

2929
```sh
30-
make protoc_abci
30+
./scripts/protoc.sh
3131
```
3232

3333
See `protoc --help` and [the Protocol Buffers site](https://developers.google.com/protocol-buffers)

‎sei-tendermint/cmd/contract_tests/main.go‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎sei-tendermint/proto/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ The `.proto` files within this section are core to the protocol and updates must
1313
1a. Submission of an RFC as a pull request should be made to facilitate further discussion.
1414
1b. Merge the RFC.
1515
2. Make the necessary changes to the `.proto` file(s).
16-
3. Rebuild the Go protocol buffers by running `make proto-gen`. Ensure that the project builds correctly by running `make build`.
16+
3. Rebuild the Go protocol buffers by running `./scripts/protoc.sh` from the root of the repo. Ensure that the project builds correctly by running `make build`.

0 commit comments

Comments
 (0)