Repository navigation
Commit 37abd47
authored
Parse extractAsUint256 values as unsigned decimal integers (#4894)
`extractAsUint256` on the JSON precompile parsed its value with
`big.Int.SetString`, which takes a wider input grammar than the unsigned
`uint256` the method returns.
`ExtractAsUint256` now accepts only a plain string of decimal digits,
quoted or unquoted, and returns an error for any other form. Gas and the
100-character length cap are unchanged.
Inputs outside that form now revert where they previously returned a
value, so this is app-hash-breaking. Covered by the extended
`TestExtractAsUint256`.1 parent 90b7acf commit 37abd47
2 files changed
Lines changed: 15 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
196 | | - | |
| 195 | + | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
107 | 108 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
120 | 126 | | |
121 | 127 | | |
122 | 128 | | |
| |||
0 commit comments