Repository navigation
Commit 2949d8d
authored
Resume scan-era cursors on the delegation-by-validator index (#4688)
Follow-up to #4518, part of PLT-980. Once the delegation-by-validator
index is ready, `ValidatorDelegations` handed a `next_key` issued by the
scan path (`len|delegator|len|validator`) straight to the index
paginator, which pages by `len|delegator`. The delegator that should
start the next page sorts before such a key and was silently dropped,
and a reverse page with such a key was served instead of refused. The
index path also paginated with `query.Paginate`, so the staking
precompile's results inside DeliverTx depended on the shared driver
rather than the release/v6.6 paginator the scan path pins, and an index
entry without its delegation decoded to an empty `Delegation` and
panicked the query.
`validatorDelegationsFromIndex` now pages through
`query.FilteredPaginateForContext`, as `validatorDelegationsFromScan`
does. `withIndexCursor` translates a key longer than one length-prefixed
delegator: a forward page resumes at that delegator when its delegation
to the requested validator sorts at or after the key, and otherwise
keeps the key, which the index already resumes after that delegator. A
reverse page with such a key returns `InvalidArgument`. The cursor's
validator is deliberately not matched against the request, because the
scan's `next_key` names whichever delegation row comes next, usually for
another validator. A missing primary row now returns `Internal`.
This changes consensus-visible precompile output only once the index is
ready, and v6.8 is not yet applied or scheduled on pacific-1 or
atlantic-2. ABCI queries on the index path now get the same limit and
offset caps as the scan path. The new keeper tests take cursors from the
scan, mark the index ready and check the continued pages match the scan
in both consensus and ABCI contexts, check the reverse refusal and the
orphan entry, and fail without the fix.1 parent b936db3 commit 2949d8d
2 files changed
Lines changed: 123 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
| |||
386 | 389 | | |
387 | 390 | | |
388 | 391 | | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| |||
132 | 134 | | |
133 | 135 | | |
134 | 136 | | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
139 | 152 | | |
140 | | - | |
| 153 | + | |
141 | 154 | | |
142 | 155 | | |
143 | | - | |
| 156 | + | |
144 | 157 | | |
145 | 158 | | |
146 | 159 | | |
147 | 160 | | |
148 | 161 | | |
149 | 162 | | |
150 | 163 | | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
151 | 190 | | |
152 | 191 | | |
153 | 192 | | |
| |||
0 commit comments