Skip to content

Commit 2362063

Browse files
ci(seidroid): bump uci seidroid-review to v0.0.25 and approve on a clean review (#4401)
Each `@seidroid review` currently posts two reviews: a COMMENTED review with the verdict and inline findings, and a second CHANGES_REQUESTED review that only holds boilerplate (for example #4376 (review)). A clean verdict also lands only as a plain PR comment, because sei-chain alone among the callers set `approve-on-success: false`, so it never shows in the reviewers panel the way it does in platform, sei-load, sei-k8s-controller and sei-internal-skills. This bumps the three `seidroid-review.yml` pins from v0.0.24 to uci v0.0.25 (https://github.com/sei-protocol/uci/releases/tag/v0.0.25), still pinned by SHA (`fcdcbede…`). In v0.0.25 the review that carries the verdict and inline findings is submitted with `REQUEST_CHANGES`/`APPROVE` itself. It also reads and resolves finding threads under the correct GraphQL bot login, and checks the head again before it withdraws an earlier block. The review job now sets `approve-on-success: true`, so a clean verdict is submitted as an APPROVED review, as the other repositories already do. v0.0.25 changes no inputs. With approval on, a seidroid APPROVE counts toward sei-chain's review requirement where branch protection counts App reviews. The comment above `seidroid-review-close` about the teardown grammar is unaffected: PLT-1182 is still open in uci. Link to Devin session: https://app.devin.ai/sessions/9e65f0b138c84a248927a0aac3c24060 Open in Devin Desktop: https://app.devin.ai/desktop/session/9e65f0b138c84a248927a0aac3c24060?variant=devin Requested by: @bdchatham --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent 5f90247 commit 2362063

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎.github/workflows/seidroid.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
'@seidroid review') &&
2626
!contains(github.event.comment.body || github.event.review.body,
2727
'@seidroid review close'))
28-
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@ad9635aeeaec226785dd1756f666cffc538981f8 # v0.0.24
28+
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@fcdcbede12a3be1a0331ab8ff2e2416c6a4db05d # v0.0.25
2929
permissions:
3030
contents: read
3131
pull-requests: write
@@ -39,11 +39,11 @@ jobs:
3939
mode: review
4040
allowed-team: 'sei-protocol/sei-core'
4141
allowed-bots: '["seidroid[bot]"]'
42-
approve-on-success: false
42+
approve-on-success: true
4343

4444
# Anchored, unlike the review job's `contains`. A comment that quotes the
4545
# teardown command beside a real `@seidroid review` line would otherwise route
46-
# here, and uci v0.0.24 admits it on the review line without checking it
46+
# here, and uci v0.0.25 admits it on the review line without checking it
4747
# against `mode`, so the session would be destroyed. Anchoring only this,
4848
# destructive, job keeps such a comment from destroying anything. PLT-1182
4949
# fixes the grammar once in uci, which can compare the parsed line to `mode`.
@@ -52,7 +52,7 @@ jobs:
5252
github.event_name == 'issue_comment' &&
5353
github.event.issue.pull_request != null &&
5454
startsWith(github.event.comment.body, '@seidroid review close')
55-
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@ad9635aeeaec226785dd1756f666cffc538981f8 # v0.0.24
55+
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@fcdcbede12a3be1a0331ab8ff2e2416c6a4db05d # v0.0.25
5656
permissions:
5757
contents: read
5858
pull-requests: write
@@ -68,7 +68,7 @@ jobs:
6868

6969
seidroid-review-reclaim:
7070
if: github.event_name == 'pull_request' && github.event.action == 'closed'
71-
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@ad9635aeeaec226785dd1756f666cffc538981f8 # v0.0.24
71+
uses: sei-protocol/uci/.github/workflows/seidroid-review.yml@fcdcbede12a3be1a0331ab8ff2e2416c6a4db05d # v0.0.25
7272
permissions:
7373
contents: read
7474
pull-requests: write

0 commit comments

Comments
 (0)