Repository navigation
Commit 2362063
ci(seidroid): bump uci seidroid-review to v0.0.25 and approve on a clean review (#4401)
Each `@seidroid review` currently posts two reviews: a COMMENTED review
with the verdict and inline findings, and a second CHANGES_REQUESTED
review that only holds boilerplate (for example
#4376 (review)).
A clean verdict also lands only as a plain PR comment, because sei-chain
alone among the callers set `approve-on-success: false`, so it never
shows in the reviewers panel the way it does in platform, sei-load,
sei-k8s-controller and sei-internal-skills.
This bumps the three `seidroid-review.yml` pins from v0.0.24 to uci
v0.0.25 (https://github.com/sei-protocol/uci/releases/tag/v0.0.25),
still pinned by SHA (`fcdcbede…`). In v0.0.25 the review that carries
the verdict and inline findings is submitted with
`REQUEST_CHANGES`/`APPROVE` itself. It also reads and resolves finding
threads under the correct GraphQL bot login, and checks the head again
before it withdraws an earlier block. The review job now sets
`approve-on-success: true`, so a clean verdict is submitted as an
APPROVED review, as the other repositories already do.
v0.0.25 changes no inputs. With approval on, a seidroid APPROVE counts
toward sei-chain's review requirement where branch protection counts App
reviews. The comment above `seidroid-review-close` about the teardown
grammar is unaffected: PLT-1182 is still open in uci.
Link to Devin session:
https://app.devin.ai/sessions/9e65f0b138c84a248927a0aac3c24060
Open in Devin Desktop:
https://app.devin.ai/desktop/session/9e65f0b138c84a248927a0aac3c24060?variant=devin
Requested by: @bdchatham
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>1 parent 5f90247 commit 2362063
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
0 commit comments