Update Seidroid review behavior - #103
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
This PR updates the pinned shared UCI review and assistant workflows from v0.0.13 to v0.0.21 and adds the comment and label triggers that the new review flow needs. I found no correctness or security problems. The new triggers rely on the upstream reusable workflow for gating (allowed-team / allowed-bots), so there is one optional efficiency suggestion.
Findings: 0 blocking | 1 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- [suggestion]
ai-review.ymlnow starts a workflow run for every PR conversation comment, review comment, review submission, and label add or remove. Any filtering for@seidroid reviewor theai: nitpicklabel happens inside the reusable workflow. A cheap job-levelifwould avoid most of those wasted runs, for example: for comment events, run only when the body contains@seidroid; for label events, run only whengithub.event.label.nameisai: nitpick. This assumes the upstream workflow doesn't need to see the other events.
PR SummaryLow Risk Overview The AI Review workflow gains broader triggers so review behavior can respond to PR label changes ( New inputs passed into the shared review workflow: Reviewed by Cursor Bugbot for commit 2018f73. Bugbot is set up for automated code reviews on this repo. Configure here. |
Summary
@seidroid reviewai: nitpicklabel