Skip to content

Update Seidroid review behavior - #103

Merged
amir-deris merged 1 commit into
mainfrom
amir/bump-uci-version
Sep 25, 2026
Merged

amir-deris merged 1 commit into
mainfrom
amir/bump-uci-version

Conversation

@amir-deris

@amir-deris amir-deris commented Sep 24, 2026 •

Copy link
Copy Markdown

Summary

  • bump the shared UCI review and assistant workflows from v0.0.13 to v0.0.21
  • make repeat reviews explicit through @seidroid review
  • make nit-level feedback opt-in through the ai: nitpick label
  • enable comment and label events required by the current review workflow

Co-authored-by: Cursor <cursoragent@cursor.com>
@amir-deris
amir-deris requested a review from masih September 24, 2026 16:35
@amir-deris amir-deris self-assigned this Sep 24, 2026

@seidroid seidroid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the pinned shared UCI review and assistant workflows from v0.0.13 to v0.0.21 and adds the comment and label triggers that the new review flow needs. I found no correctness or security problems. The new triggers rely on the upstream reusable workflow for gating (allowed-team / allowed-bots), so there is one optional efficiency suggestion.

Findings: 0 blocking | 1 non-blocking | 0 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • [suggestion] ai-review.yml now starts a workflow run for every PR conversation comment, review comment, review submission, and label add or remove. Any filtering for @seidroid review or the ai: nitpick label happens inside the reusable workflow. A cheap job-level if would avoid most of those wasted runs, for example: for comment events, run only when the body contains @seidroid; for label events, run only when github.event.label.name is ai: nitpick. This assumes the upstream workflow doesn't need to see the other events.

@cursor

cursor Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes only affect GitHub Actions wiring and UCI pins; no application runtime or security-sensitive code paths.

Overview
Updates Seidroid/UCI integration by pinning both ai-assist and ai-review reusable workflows from v0.0.13 to v0.0.21 (new commit SHA and release comment).

The AI Review workflow gains broader triggers so review behavior can respond to PR label changes (labeled / unlabeled), issue comments, review comments, and submitted reviews—supporting on-demand repeats (e.g. @seidroid review) and opt-in nit-level feedback via the ai: nitpick label as implemented in the newer UCI release. A job-level guard skips issue_comment events that are not on pull requests.

New inputs passed into the shared review workflow: allowed-team (sei-protocol/sei-core) and allowed-bots (seidroid[bot]). Cursor-based review remains disabled via enable-cursor: false.

Reviewed by Cursor Bugbot for commit 2018f73. Bugbot is set up for automated code reviews on this repo. Configure here.

@amir-deris
amir-deris merged commit 6436041 into main Sep 25, 2026
22 checks passed
@amir-deris
amir-deris deleted the amir/bump-uci-version branch September 25, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants