revert: drop tolerance for malformed payloads

Handling values the SDK does not recognize is forward compatibility. Tolerating
payloads that are malformed rather than merely new is a bug being swallowed, and
the two were conflated here.

Removes the non-Hash guard in process_data_attributes and the rescue in
parse_datetime. A response that is not an object, or a timestamp that is not a
timestamp, is a defect worth surfacing rather than reading as an empty resource
or nil. The webhook path already rejects a non-object body with
InvalidWebhookPayloadError, so nothing reaches process_data_attributes that way.

Unrecognized handling is untouched: unknown event types still fall back to a
generic SeamEvent, unknown error codes to the base error class, and unknown enum
values read as themselves.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M2kJ4nGaM8imZCVMEKjmXA

Author: claude

lib/seam/base_resource.rb

@@ -112,13 +112,9 @@ def self.date_accessor(*attrs)
 
       def parse_datetime(value)
         Time.parse(value)
-      rescue ArgumentError, TypeError
-        nil
       end
 
       def process_data_attributes(data)
-        return unless data.is_a?(Hash)
-
         data.each do |key, value|
           next unless key.to_s.match?(/\A[a-zA-Z_][a-zA-Z0-9_]*\z/)
 

spec/resources/total_parsing_spec.rb …/resources/forward_compatibility_spec.rbspec/resources/total_parsing_spec.rb renamed to spec/resources/forward_compatibility_spec.rb spec/resources/total_parsing_spec.rb renamed to spec/resources/forward_compatibility_spec.rb

@@ -1,28 +1,24 @@
 # frozen_string_literal: true
 
-# Reading a response must not fail on the shape of the payload.
-RSpec.describe "total parsing" do
-  it "does not raise when the payload is not an object" do
-    resource = Seam::Resources::Device.load_from_response(42)
-
-    expect(resource).to be_a(Seam::Resources::Device)
-    expect(resource.device_id).to be_nil
-  end
-
-  it "does not raise when a list payload holds values that are not objects" do
-    resources = Seam::Resources::Device.load_from_response([1, 2])
-
-    expect(resources.map(&:class)).to eq(
-      [Seam::Resources::Device, Seam::Resources::Device]
+# Seam adds event types, action types, and enum values between SDK releases.
+# Reading them must not raise; writing logic against them is what an upgrade is
+# for. The webhook event additionally carries the payload it was parsed from.
+RSpec.describe "forward compatibility" do
+  it "reads an unknown enum value as itself" do
+    device = Seam::Resources::Device.load_from_response(
+      "device_id" => "device_1", "device_type" => "future_lock"
     )
+
+    expect(device.device_type).to eq("future_lock")
   end
 
-  it "reads a list property sent as a scalar as empty" do
-    device = Seam::Resources::Device.load_from_response(
-      "device_id" => "device_1", "errors" => "oops"
+  it "falls back to a generic event for an unknown event type" do
+    event = Seam::Resources::SeamEvent.load_from_response(
+      "event_id" => "event_1", "event_type" => "future.thing"
     )
 
-    expect(device.errors).to eq([])
+    expect(event.class).to eq(Seam::Resources::SeamEvent)
+    expect(event.event_type).to eq("future.thing")
   end
 
   it "keeps the rest of the resource when an error code is unknown" do
@@ -36,31 +32,19 @@
     expect(device.errors.first.error_code).to eq("brand_new")
   end
 
-  it "reads a malformed timestamp as nil" do
-    device = Seam::Resources::Device.load_from_response(
-      "device_id" => "device_1", "created_at" => "not a timestamp"
-    )
-
-    expect(device.created_at).to be_nil
-  end
-
-  it "reads a timestamp of the wrong type as nil" do
-    device = Seam::Resources::Device.load_from_response(
-      "device_id" => "device_1", "created_at" => 12345
-    )
-
-    expect(device.created_at).to be_nil
-  end
-
-  it "still parses a well-formed timestamp" do
-    device = Seam::Resources::Device.load_from_response(
-      "device_id" => "device_1", "created_at" => "2024-01-01T00:00:00Z"
+  it "reads an unknown action attempt status as itself" do
+    attempt = Seam::Resources::ActionAttempt.load_from_response(
+      "action_attempt_id" => "attempt_1",
+      "action_type" => "LOCK_DOOR",
+      "status" => "cancelled"
     )
 
-    expect(device.created_at).to be_a(Time)
+    expect(attempt.status).to eq("cancelled")
   end
 end
 
+# Waiting promises a succeeded attempt or a raise, so an unrecognized status is
+# the one place the SDK must not stay quiet.
 RSpec.describe Seam::ActionAttemptUnknownStatusError do
   it "is raised rather than returning an unresolved attempt as a success" do
     attempt = Seam::Resources::ActionAttempt.load_from_response(
@@ -95,7 +79,6 @@
 
     event = Seam::Resources::SeamEvent.load_from_response(payload)
 
-    expect(event.class).to eq(Seam::Resources::SeamEvent)
     expect(JSON.parse(event.raw_json)).to eq(payload)
   end