Set Patchwork status

[matttbe]

Hello,

It would be nice if Sashiko can update Patchwork status when starting/finishing a review as Patchwork is often used to track patches and gather info about them.

It will require a token and permissions on Patchwork side to be able to do that.

On my side, as a temporarily/permanent solution, I will check if our CI could try to poll results using Sashiko's API if that's OK to poll them. (I didn't find a doc about this API, but the website's source code pointed me to https://sashiko.dev/api/patch?id=${MESSAGE_ID} which seems to have everything I need :) )

[rgushchin]

Hey!

Do you have an instance of patchwork I can play with and test the integration? It's not hard to add this to Sashiko, but from what I heard (no direct experience, sorry) setting up patchwork is not exactly trivial and no one of my colleagues maintainers are using it.

And yes, please, feel free to poll results.

[matttbe]

Hey @rgushchin

Thank you for your reply!

Do you have an instance of patchwork I can play with and test the integration?

Like many other maintainers, I'm using the one from kernel.org.

If you are OK, I can ask the helpdesk to create an account with permissions to post checks to the MPTCP project. If yes, I will need an email address (can also be yours with a +sashiko, or a dedicated one) and a name. Or, if you prefer, feel free to send this email with me in Cc, and I will ACK it.

It's not hard to add this to Sashiko, but from what I heard (no direct experience, sorry) setting up patchwork is not exactly trivial and no one of my colleagues maintainers are using it.

Yes indeed. And because many projects are on the one from kernel.org, why not directly using it :)

For Patchwork, I guess you noticed, but once you have a token, it is just a matter of sending a POST:

• Overview: https://patchwork.readthedocs.io/en/latest/usage/overview/#checks
• API (latest): https://patchwork.readthedocs.io/en/latest/api/rest/schemas/v1.3/#post--api-1.3-patches-patch_id-checks

And yes, please, feel free to poll results.

Great! I didn't have a chance to look at it yet, but I know what to do if needed!

[rgushchin]

@matttbe Can you please authorize sashiko-bot@kernel.org to post changes?

[matttbe]

@rgushchin I just asked helpdesk to create a new patchwork user with the right permissions. When sending the email, I cc'ed this kernel.org address but I got an error saying this address doesn't exist. Did I miss something?

[rgushchin]

It certainly works for sending emails (I'm plumbing Sashiko to be able to send emails with reviews), but I don't have an ability to read anything sent to it. I just asked kernel.org guys to setup the forwarding to my email.

[matttbe]

OK thanks, that's clear!

[matttbe]

Hi @rgushchin,

I didn't get any reply from my email to helpdesk from 3 weeks ago. Were you in discussion with them recently regarding sashiko-bot email or something else?

A few minutes ago, I was talking to Netdev maintainers who would like to have Sashiko's results on their Patchwork as well :)

[rgushchin]

Yeah, @matttbe , I haven't heard from them either. I can create a formal ticket, maybe it will help.

[matttbe]

If you don't mind, yes please. (Or ACKing my previous email?)

[vinodkoul]

Hey, do we know when this feature would be available? I have PW instances for SS I maintain, and would like Sashiko to update PW status.

[mchehab]

FYI, I added yesterday a PR allowing patchwork to be granted with either a globalwide or a projectwide support for adding checks:
getpatchwork/patchwork#653

[derekbarbosa]

As heads up, #253 was merged.