Skip to content

Commit dc8d1b7

Browse files
rbenzingclaude
andcommitted
release: document silent cross-version break and fix CI version source
The 2.8.0 group signature format change is not detectable at runtime: group messages carry no protocol-version field and IsCompatible treats every 2.x peer as compatible, so a mixed-version group drops messages one at a time with no exception reaching the caller. Documented, with the security-event log line operators should watch for, and an explicit note that shipping a protocol break as a minor deviates from VERSIONING.md. CI determined the version for main builds from a hardcoded "2.0.0", mislabelling every artifact built from main since 2.0. Now read from Directory.Build.props, failing the build if it cannot be parsed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent e88cedc commit dc8d1b7

2 files changed

Lines changed: 22 additions & 1 deletion

File tree

‎.github/workflows/dotnet.yml‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,14 @@ jobs:
3232
if [[ "${{ github.ref }}" == refs/tags/v* ]]; then
3333
VERSION=${GITHUB_REF#refs/tags/v}
3434
elif [[ "${{ github.ref_name }}" == "main" ]]; then
35-
VERSION="2.0.0"
35+
# Read the real version from Directory.Build.props rather than hardcoding it.
36+
# A hardcoded value silently mislabels every artifact built from main whenever
37+
# VersionPrefix moves ahead of it.
38+
VERSION=$(sed -n 's|.*<VersionPrefix>\(.*\)</VersionPrefix>.*|\1|p' Directory.Build.props | head -1)
39+
if [[ -z "$VERSION" ]]; then
40+
echo "::error::Could not read VersionPrefix from Directory.Build.props"
41+
exit 1
42+
fi
3643
elif [[ "${{ github.ref_name }}" == "legacy-1.0" ]]; then
3744
VERSION="1.0.0"
3845
elif [[ "${{ github.ref_name }}" == "experimental" ]]; then

‎CHANGELOG.md‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
6262
peers, or vice versa.** All members of a group must upgrade together. One-to-one chat
6363
sessions are unaffected.
6464

65+
**This failure is silent.** Group messages carry no protocol-version field, and
66+
`ProtocolVersion.IsCompatible` treats every 2.x peer as compatible, so a mixed-version
67+
group does not detect the mismatch. Cross-version messages are rejected one at a time and
68+
`DecryptMessageAsync` returns `null` — no exception reaches the caller. The rejections are
69+
recorded via `LoggingManager.LogSecurityEvent` (message: "signature verification failed"),
70+
so **enable security-event logging before upgrading a group incrementally**, or the
71+
symptom is simply that some members stop receiving messages with no error surfaced.
72+
73+
**Note on version numbering.** `VERSIONING.md` reserves MAJOR for "breaking changes to
74+
the public API or protocol", so by that rule this change belongs in 3.0.0. It ships as a
75+
minor deliberately: the public API is unchanged, and the backward-compatible security
76+
fixes above were judged too important to hold behind the v3.0 milestone. Do not infer
77+
from the version number that 2.7.x and 2.8.0 group members interoperate — they do not.
78+
6579
## [2.7.0] - 2026-08-02
6680

6781
Security and protocol-correctness release. Fixes two key-handling defects that could zero or

0 commit comments

Comments
 (0)