fix: automate base theme extraction from global.css in extract-theme-css.ts - #1183
Open
syrfmy wants to merge 1 commit into
Open
fix: automate base theme extraction from global.css in extract-theme-css.ts#1183syrfmy wants to merge 1 commit into
syrfmy wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: eb1acc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
syrfmy
force-pushed
the
fix/automate-base-theme-extraction
branch
from
August 7, 2026 04:12
55dc923 to
b8255c4
Compare
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
syrfmy
force-pushed
the
fix/automate-base-theme-extraction
branch
from
August 10, 2026 15:23
b8255c4 to
eb1acc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
Closes #1123
The base theme in
extract-theme-css.tswas hardcoded as a copy ofglobal.css. Instead of manually keeping them in sync, this PR extracts it dynamically so it's always up to date.Also fixed a missing
--shadow-2xsvariable in the test fixture ofextract-theme-css.spec.ts.Checklist:
pnpm changeand documented my changes