fix: Merge E2E tests into docker-build job so image is available

The E2E job ran on a separate runner and couldn't access the Docker
image built by docker-build. Its own build attempt also failed
because gpredomics/gpredomicspy weren't checked out. Now E2E steps
run in the same job, reusing the image, with its own postgres
instance on port 8001.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: eprifti

.github/workflows/ci.yml

@@ -58,7 +58,7 @@ jobs:
         run: npm run build
 
   # -------------------------------------------------------------------------
-  # Docker build (full stack)
+  # Docker build + E2E tests (full stack)
   # -------------------------------------------------------------------------
   docker-build:
     runs-on: ubuntu-latest
@@ -129,40 +129,40 @@ jobs:
           docker network rm test-net
           exit 1
 
-  # -------------------------------------------------------------------------
-  # E2E tests (Playwright against Docker)
-  # -------------------------------------------------------------------------
-  e2e-test:
-    runs-on: ubuntu-latest
-    needs: [docker-build]
-    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
-
-    steps:
-      - uses: actions/checkout@v4
+      # --- E2E tests (Playwright against the Docker image we just built) ---
 
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
           node-version: "20"
 
-      - name: Install dependencies
+      - name: Install E2E dependencies
+        working-directory: predomicsapp-web
         run: npm ci
 
       - name: Install Playwright browser
+        working-directory: predomicsapp-web
         run: npx playwright install chromium
 
-      - name: Build Docker image for E2E
-        run: |
-          docker build -t predomicsapp-web:e2e -f Dockerfile ../ 2>/dev/null || echo "Using cached image"
-
-      - name: Start app
+      - name: Start app for E2E
         run: |
-          docker run -d --name e2e-app -p 8001:8000 \
-            -e PREDOMICS_SECRET_KEY=e2e-test-secret \
-            predomicsapp-web:latest 2>/dev/null || \
-          docker run -d --name e2e-app -p 8001:8000 \
+          docker network create e2e-net
+          docker run -d --name e2e-db --network e2e-net \
+            -e POSTGRES_USER=predomics \
+            -e POSTGRES_PASSWORD=predomics \
+            -e POSTGRES_DB=predomics \
+            postgres:16-alpine
+          for i in $(seq 1 15); do
+            if docker exec e2e-db pg_isready -U predomics > /dev/null 2>&1; then
+              echo "Postgres ready on attempt $i"
+              break
+            fi
+            sleep 2
+          done
+          docker run -d --name e2e-app --network e2e-net -p 8001:8000 \
+            -e PREDOMICS_DATABASE_URL=postgresql+asyncpg://predomics:predomics@e2e-db:5432/predomics \
             -e PREDOMICS_SECRET_KEY=e2e-test-secret \
-            predomicsapp-web:e2e
+            predomicsapp-web:latest
           for i in $(seq 1 30); do
             if curl -sf http://localhost:8001/health; then
               echo "App ready on attempt $i"
@@ -173,10 +173,13 @@ jobs:
           done
 
       - name: Run E2E tests
+        working-directory: predomicsapp-web
         run: npm run test:e2e
         env:
           BASE_URL: http://localhost:8001
 
-      - name: Cleanup
+      - name: E2E cleanup
         if: always()
-        run: docker stop e2e-app 2>/dev/null || true
+        run: |
+          docker stop e2e-app e2e-db 2>/dev/null || true
+          docker network rm e2e-net 2>/dev/null || true