Skip to content

Commit 6faf4c0

Browse files
committed
fix: add missing cinfo import in lasso.rs, fix all clippy warnings
1 parent 1a3f09b commit 6faf4c0

4 files changed

Lines changed: 8 additions & 12 deletions

File tree

‎src/bayesian_mcmc.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ impl MCMCAnalysisTrace {
554554
log_post_trace: Vec::with_capacity(n_features),
555555
post_mean: 0.0,
556556
post_var: 0.0,
557-
param: param,
557+
param,
558558
}
559559
}
560560

@@ -1033,8 +1033,8 @@ pub fn compute_mcmc(bp: &BayesPred, param: &Param, rng: &mut ChaCha8Rng) -> MCMC
10331033
}
10341034
for i in 0..nbeta {
10351035
let cost = NegLogPostToMinimize {
1036-
bp: bp,
1037-
i: i,
1036+
bp,
1037+
i,
10381038
ind: &ind,
10391039
z: &z,
10401040
};

‎src/cv.rs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -403,9 +403,7 @@ impl CV {
403403
importances.push(collection_importance);
404404
}
405405

406-
Ok(ImportanceCollection {
407-
importances: importances,
408-
})
406+
Ok(ImportanceCollection { importances })
409407
}
410408

411409
/// Extracts the `Family of Best Models` population for a specific fold.
@@ -621,7 +619,7 @@ impl CV {
621619
Ok(CV {
622620
validation_folds,
623621
training_sets,
624-
fold_collections: fold_collections,
622+
fold_collections,
625623
})
626624
}
627625
}

‎src/data.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1287,7 +1287,7 @@ impl Data {
12871287
});
12881288

12891289
Data {
1290-
X: X,
1290+
X,
12911291
y: samples.iter().map(|i| self.y[*i]).collect(),
12921292
features: self.features.clone(),
12931293
samples: samples.iter().map(|i| self.samples[*i].clone()).collect(),
@@ -1298,7 +1298,7 @@ impl Data {
12981298
sample_len: samples.len(),
12991299
classes: self.classes.clone(),
13001300
feature_annotations: self.feature_annotations.clone(),
1301-
sample_annotations: sample_annotations,
1301+
sample_annotations,
13021302
}
13031303
}
13041304

@@ -1313,7 +1313,7 @@ impl Data {
13131313
/// A new Data instance with the updated feature matrix.
13141314
pub fn clone_with_new_x(&self, X: HashMap<(usize, usize), f64>) -> Data {
13151315
Data {
1316-
X: X,
1316+
X,
13171317
y: self.y.clone(),
13181318
features: self.features.clone(),
13191319
samples: self.samples.clone(),

‎src/param.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use std::error::Error;
88

99
#[derive(Debug, Serialize, Deserialize, Clone, PartialEq)]
1010
#[allow(non_camel_case_types)]
11-
1211
/// Fit function options for model evaluation
1312
pub enum FitFunction {
1413
/// Area Under the Curve (AUC) of the Receiver Operating Characteristic (ROC)
@@ -1180,7 +1179,6 @@ fn validate_penalties(param: &mut Param) -> Result<(), String> {
11801179
}
11811180

11821181
/// Default value definitions
1183-
11841182
fn seed_default() -> u64 {
11851183
4815162342
11861184
}

0 commit comments

Comments
 (0)