ext/session: Add tests for session_regenerate_id() write/destroy failure paths#22687
Open
jorgsowa wants to merge 1 commit into
Open
ext/session: Add tests for session_regenerate_id() write/destroy failure paths#22687jorgsowa wants to merge 1 commit into
jorgsowa wants to merge 1 commit into
Conversation
LamentXU123
approved these changes
Jul 11, 2026
Covers the previously untested FAILURE branches where a userland save handler's write() or destroy() returns false during session_regenerate_id(), which should warn and return false while leaving the current session ID untouched.
jorgsowa
force-pushed
the
session-regenerate-id-tests
branch
from
July 18, 2026 21:10
0f97356 to
30f5e21
Compare
Member
|
@Girgias Can you please take a quick look at these tests? This looks fine but I am not familiar with the session extension :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers
FAILUREbranches where a userland save handler's write() or destroy() returns false duringsession_regenerate_id(), which should warn and return false while leaving the current session ID unchanged.