Conversation
Contributor
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Member
Author
|
I note that coverage reporting seems to be totally broken. This isn't even a fork and it's still failing to pick up the changed files correctly 😞 |
- use format_error for hdf5 availability error - open hdf5 with context manager - no single-character variable names - tweak docstrings
- TypedDict for crystal dict output - Use h5py feature to guarantee string output (not bytes) - Fix POMASS priority order - Fix fractional coordinate rounding - Force amu/Ang units, simplifying params
In an NSW=0 calculation the positions are not a result so should be read from input. This occurs for post-processing QPOINTS runs. If there _is_ a structure in results we should use it as the stucture may have been optimised.
Don't quietly pass onto POTCAR data if INCAR data is bad.
- This introduced a nasty challenge: the final structure in results/positions can include finite displacements from Hessian calculation. Clearly we don't want that in our reference structure. For now fallback to the input structure, but that also has possible problems...
Testing suggests that ibrion=6 calculations don't actually do optimisation to update the base positions, but they do tend to leave a displaced structure in "results". So it seems safest to always use the input structure if we didn't get a primitive transformation; that also streamlines the code a bit.
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
Woohoo, rebased and the new coverage reporter seems to be working 🎉 |
oerc0122
reviewed
Aug 13, 2026
| # 1. Try active input/incar/POMASS | ||
| if 'input/incar/POMASS' in h5_file: | ||
| val = h5_file['input/incar/POMASS'].asstr()[()] | ||
| raw_vals = re.findall(r'[0-9.]+', str(val)) |
Collaborator
There was a problem hiding this comment.
Does this need casting to str again?
Also, would it be "better" to use finditer, build the list from that, then check whether the list has elements before returning?
Member
Author
There was a problem hiding this comment.
Nope, the str is redundant. I've refactored this function to be a bit flatter, DRYer with more walrus; take a look!
ajjackson
marked this pull request as ready for review
August 17, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent (relatively-speaking) versions of VASP have improved phonon calculation features and a machine-friendly .h5 file output. This makes it a lot more attractive to include some built-in support. A tricky point is that various calculation types will produce an identically-named .h5 file so a bit of intelligence is needed to identify if relevant information is available:
An IBRION=[5-8] calculation will produce a Hessian for the whole simulation cell. VASP might identify the supercell nature and use this to reduce the number of displacements, but we still get a 3Nx3N set of force constants. For now we do not look for a primitive cell in this case, and treat the system as though it is primitive. That will give correct DOS and INS simulations for a supercell calculation, but at increased cost compared with a more sophisticated scheme. (Band structures will include folding and incorrect symmetry labels.)
If QPOINTS are provided and PHON_DOS is set, VASP will do q-point interpolation and produce a dataset with defined primitive cell and sufficient data to construct QpointPhononModes. The force constants may be present, but can also be missing if the file was produced in a "post-processing" run on an existing .h5 file.
If both force constants and primitive cell are defined, we can attempt to map the force constants to primitive as we do for Phonopy. Less metadata is available so for now we naively try to solve for the supercell matrix. This might go wrong in non-trivial cases, but so do some Phonopy imports at the moment; probably they can be fixed together in future. In (fairly common) trivial diagonal supercell cases we should be fine.
https://vasp.at/wiki/Computing_the_phonon_dispersion_and_DOS
h5py is an optional dependency included in the existing phonopy-reader dependency group, so we re-use that in packaging/CI infrastructure. (phonopy-reader also includes YAML, but VASP doesn't need it.)
At the moment I've put the tests in a new vasp_reader group. But perhaps life would be simpler if they shared phonopy_reader.