radsecproxy: add more config options for UCI#30044
Conversation
f09a6a6 to
01223a0
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. One inline note on package release hygiene; the commit message accurately describes the change.
Generated by Claude Code
|
needs PKG_RELEASE version bump rest looks fine |
|
I'm right now looking at more config options, so I'll push an update, and add the PKG_RELEASE version bump in there as well. Unfortunately the init script also needs a change, because right now everything is escaped with single quotes, and the single quote has a special meaning for the attribute rewrites. |
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed the new commit (dc02adaa). The PKG_RELEASE bump requested earlier is now in place and the commit message matches the changes. Two inline issues on the new init-script changes: a shell syntax error in the escaping case block, and a misspelled TLS directive.
Generated by Claude Code
This adds more config options for use in UCI, esp. new configuration options that were introduced in newer radsecproxy versions and it fixes an escaping issue in the init script where a string containing single quotes would still be escaped using single quotes, causing radsecproxy to reject the config. This also bumps the PKG_RELEASE in the Makefile Signed-off-by: Jan-Frederik Rieckers <rieckers@dfn.de>
ec86ec4 to
de9a715
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
The series was squashed into a single commit. The only new changes since the last review are the two fixes previously flagged: the case block now has ;; terminators, and the TLS directive is corrected to CipherSuites. Both are correct. No new issues found.
Generated by Claude Code
📦 Package Details
Maintainer: @commodo
Description:
This patch adds additional configuration options that can come from the UCI config files.
🧪 Run Testing Details
✅ Formalities