Skip to content

radsecproxy: add more config options for UCI#30044

Open
Janfred wants to merge 1 commit into
openwrt:masterfrom
Janfred:feature_radsecproxy
Open

radsecproxy: add more config options for UCI#30044
Janfred wants to merge 1 commit into
openwrt:masterfrom
Janfred:feature_radsecproxy

Conversation

@Janfred

@Janfred Janfred commented Jul 19, 2026

Copy link
Copy Markdown

📦 Package Details

Maintainer: @commodo

Description:
This patch adds additional configuration options that can come from the UCI config files.


🧪 Run Testing Details

  • OpenWrt Version: 25.12.5 r33051-f5dae5ece4
  • OpenWrt Target/Subtarget: ath79/generic
  • OpenWrt Device: TP-Link Archer C7 v5

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@Janfred
Janfred force-pushed the feature_radsecproxy branch from f09a6a6 to 01223a0 Compare July 19, 2026 12:24
@Janfred Janfred changed the title WIP: radsecproxy: add more config options for UCI radsecproxy: add more config options for UCI Jul 19, 2026

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. One inline note on package release hygiene; the commit message accurately describes the change.


Generated by Claude Code

Comment thread net/radsecproxy/files/radsecproxy.init
@commodo

commodo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

needs PKG_RELEASE version bump

rest looks fine

@Janfred

Janfred commented Jul 21, 2026

Copy link
Copy Markdown
Author

I'm right now looking at more config options, so I'll push an update, and add the PKG_RELEASE version bump in there as well.

Unfortunately the init script also needs a change, because right now everything is escaped with single quotes, and the single quote has a special meaning for the attribute rewrites.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new commit (dc02adaa). The PKG_RELEASE bump requested earlier is now in place and the commit message matches the changes. Two inline issues on the new init-script changes: a shell syntax error in the escaping case block, and a misspelled TLS directive.


Generated by Claude Code

Comment thread net/radsecproxy/files/radsecproxy.init Outdated
Comment thread net/radsecproxy/files/radsecproxy.init Outdated
This adds more config options for use in UCI, esp. new configuration
options that were introduced in newer radsecproxy versions and it fixes
an escaping issue in the init script where a string containing single
quotes would still be escaped using single quotes, causing radsecproxy
to reject the config.

This also bumps the PKG_RELEASE in the Makefile

Signed-off-by: Jan-Frederik Rieckers <rieckers@dfn.de>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The series was squashed into a single commit. The only new changes since the last review are the two fixes previously flagged: the case block now has ;; terminators, and the TLS directive is corrected to CipherSuites. Both are correct. No new issues found.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants