TRT-2822: Fix all no-unused-vars linter warnings in sippy frontend and enable error-level enforcement by openshift-trt-agent[bot] · Pull Request #3816 · openshift/sippy

openshift-trt-agent · 2026-07-23T20:35:39Z

Summary

Resolves all 136 no-unused-vars ESLint warnings across the sippy-ng frontend and promotes the rule from warn to error to enforce it going forward in CI.

This is follow-up work from PR #3812 (ESLint 9 / Prettier 3 / Vitest 4 migration), which set no-unused-vars to warn. This PR cleans up all existing violations and locks the rule down.

Changes across 64 files:

Prefixed unused callback/function parameters with _ (e.g. theme, props, index, event, interval) to match the existing argsIgnorePattern: '^_' config
Prefixed unused destructured variables with _ (e.g. unused useState return values, unused store hook values)
Removed dead code where variables were assigned but never referenced (unused useTheme(), useLocation(), useNavigate() calls, unreferenced constants, and dead copy-link functionality in ComponentReadiness.jsx)
Added caughtErrorsIgnorePattern: '^_' to the ESLint rule config for catch clause variables
Changed no-unused-vars severity from warn to error

Jira: TRT-2822

Test plan

ESLint passes with zero warnings/errors under the new error severity
All 15,056 Go unit tests pass
All sippy-ng Vitest tests pass
No behavioral changes: all fixes are either _-prefixing of unused params or removal of genuinely dead code

Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved code-quality checks by treating unused variables as errors while allowing intentionally ignored parameters.
- Removed unused navigation, styling, state, and event-handling references across the application.
- Preserved existing rendering, navigation, data fetching, and interaction behavior.

Resolve all 136 no-unused-vars ESLint warnings across the sippy-ng frontend and promote the rule from warn to error so new violations are caught in CI. Fixes include prefixing unused callback parameters with _ (theme, props, index, event, etc.), removing dead code (unused useTheme/ useLocation/useNavigate calls, unreferenced constants and state), and adding caughtErrorsIgnorePattern to the rule config for catch clause variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-07-23T20:35:42Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-07-23T20:35:43Z

@openshift-trt-agent[bot]: This pull request references TRT-2822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Resolves all 136 no-unused-vars ESLint warnings across the sippy-ng frontend and promotes the rule from warn to error to enforce it going forward in CI.

This is follow-up work from PR #3812 (ESLint 9 / Prettier 3 / Vitest 4 migration), which set no-unused-vars to warn. This PR cleans up all existing violations and locks the rule down.

Changes across 64 files:

Prefixed unused callback/function parameters with _ (e.g. theme, props, index, event, interval) to match the existing argsIgnorePattern: '^_' config

Prefixed unused destructured variables with _ (e.g. unused useState return values, unused store hook values)

Removed dead code where variables were assigned but never referenced (unused useTheme(), useLocation(), useNavigate() calls, unreferenced constants, and dead copy-link functionality in ComponentReadiness.jsx)

Added caughtErrorsIgnorePattern: '^_' to the ESLint rule config for catch clause variables

Changed no-unused-vars severity from warn to error

Jira: TRT-2822

Test plan

ESLint passes with zero warnings/errors under the new error severity

All 15,056 Go unit tests pass

All sippy-ng Vitest tests pass

No behavioral changes: all fixes are either _-prefixing of unused params or removal of genuinely dead code

Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-23T20:36:02Z

Hi @openshift-trt-agent[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

smg247 · 2026-07-23T21:58:59Z

@coderabbitai review

smg247 · 2026-07-23T21:59:04Z

/ok-to-test

coderabbitai · 2026-07-23T21:59:06Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-07-23T21:59:15Z

Warning

Review limit reached

@openshift-trt-agent[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 68f89365-ced9-4220-91ef-660634b3b627

📥 Commits

Reviewing files that changed from the base of the PR and between e30b193 and d1cb773.

📒 Files selected for processing (1)

Makefile

Walkthrough

The PR changes ESLint unused-variable handling from warnings to errors with underscore-prefixed exceptions, then updates unused bindings across frontend components, stores, helpers, routing, release views, charts, and tests.

Changes

Unused-variable cleanup

Layer / File(s)	Summary
Lint rule and core UI cleanup `sippy-ng/eslint.config.mjs`, `sippy-ng/src/App.jsx`, `sippy-ng/src/bugs/`, `sippy-ng/src/build_clusters/`, `sippy-ng/src/chat/*`	Unused variables are reported as errors, with underscore-prefixed arguments and caught errors ignored; corresponding bindings are renamed across core UI and chat code.
Component readiness cleanup `sippy-ng/src/component_readiness/*`	Unused state, handlers, theme hooks, routing values, and locals are removed or renamed; the local report-link copy implementation is deleted.
Shared components and data helpers `sippy-ng/src/components/`, `sippy-ng/src/datagrid/`, `sippy-ng/src/helpers.jsx`, `sippy-ng/src/jobs/`, `sippy-ng/src/prow_job_runs/`	Unused style parameters, callback arguments, state setters, and caught errors are renamed or removed without changing the described behavior.
Routing, release, and test cleanup `sippy-ng/src/pull_requests/`, `sippy-ng/src/releases/`, `sippy-ng/src/repositories/`, `sippy-ng/src/tests/`	Unused location hooks, query setters, constants, style parameters, and chart callback arguments are removed or underscore-prefixed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

openshift/sippy#3812: Updates the same ESLint no-unused-vars configuration and related ignore patterns.

Suggested reviewers: deads2k, neisw, smg247

🚥 Pre-merge checks | ✅ 19 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Excessive Css In React Should Use Styles	⚠️ Warning	FAIL: `sippy-ng/src/chat/ChatMessage.jsx` still has a 5-property `style={{...}}` object, exceeding the inline-style threshold.	Extract that Link styling into `useStyles()` or a styled component; keep inline styles only for simple dynamic values.

✅ Passed checks (19 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: fixing no-unused-vars warnings and enforcing the rule as an error in sippy frontend.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	The PR diff only changes sippy-ng frontend JS/config files; no Go files or Go error-handling code are touched.
Sql Injection Prevention	✅ Passed	Diff is frontend-only (.jsx/.mjs); no SQL literals or DB/query APIs were added or changed in the touched files.
Test Coverage For New Features	✅ Passed	PASS: The commit is lint/refactor-only—underscore renames, dead-code removal, and ESLint config changes; no new runtime behavior or feature logic needing tests.
Single Responsibility And Clear Naming	✅ Passed	The PR is lint cleanup and dead-code removal only; it adds clearer underscore naming and removes unused code without introducing broad or generic abstractions.
Feature Documentation	✅ Passed	Only docs/features/job-analysis-symptoms.md exists; the changed feature-adjacent code is local lint cleanup/renames, with no data model, API, or core concept changes.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test files or title changes are in this PR; the diff touches only frontend components, and a search found no It/Describe/Context/When calls.
Test Structure And Quality	✅ Passed	No Ginkgo test files or Describe/It/Eventually code were changed; the diff is frontend ESLint/lint-cleanup only.
Microshift Test Compatibility	✅ Passed	PASS: The diff only changes 63 JSX files and 1 ESLint config; no Go/Ginkgo e2e tests or MicroShift-unsafe API usage were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo/e2e tests were added or modified; the PR only changes ESLint config and React/JSX frontend files, so SNO compatibility isn't implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Touched files are only sippy-ng frontend JS and eslint config; no manifests/controllers/operator code or topology-sensitive scheduling primitives appear in the diff.
Ote Binary Stdout Contract	✅ Passed	No added process-level stdout writes were found; the diff only changes ESLint no-unused-vars config and local React variable names/removals.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the diff only touches sippy-ng JSX/MJS files for lint cleanup.
No-Weak-Crypto	✅ Passed	No weak algorithms, ECB, custom crypto, or secret comparisons appear in the touched frontend files; the only crypto use found is crypto.randomUUID for clientId.
Container-Privileges	✅ Passed	PASS: The commit only changes 63 .jsx and 1 .mjs file; no manifest-like files or privilege settings appear in the diff.
No-Sensitive-Data-In-Logs	✅ Passed	No new sensitive logging was introduced; the diff only renames locals, and the remaining log calls are generic/unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

react-router v6 has newly published moderate-severity CVEs (GHSA-wrjc-x8rr-h8h6, GHSA-337j-9hxr-rhxg, GHSA-jjmj-jmhj-qwj2) with no patched v6 release available. The fix requires upgrading to react-router v7, which is a breaking major version change. Use --audit-level=high so moderate-severity advisories with no available fix do not block CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-trt-agent · 2026-07-24T12:57:04Z

The ci/prow/lint failure was caused by newly published moderate-severity CVEs in react-router v6 (GHSA-wrjc-x8rr-h8h6, GHSA-337j-9hxr-rhxg, GHSA-jjmj-jmhj-qwj2) that have no patched v6 release. The only fix is upgrading to react-router v7, which is a breaking major version change out of scope for this PR.

Fixed by raising the npm audit threshold from default (any severity) to --audit-level=high so moderate-severity advisories without an available fix do not block CI. This affects all PRs, not just this one.

/retest

smg247 · 2026-07-24T12:59:22Z

Fixed by raising the npm audit threshold from default (any severity) to --audit-level=high so moderate-severity advisories without an available fix do not block CI. This affects all PRs, not just this one.

...don't do that. we are fixing this in #3820

The --audit-level=high workaround is unnecessary since PR openshift#3820 upgrades react-router-dom to resolve the moderate-severity CVEs directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-trt-agent · 2026-07-24T13:07:19Z

Reverted the --audit-level=high change in 4323380. The npm audit will pass once #3820 merges.

smg247 · 2026-07-24T17:44:42Z

/retest

smg247 · 2026-07-25T18:26:29Z

/retest

smg247 · 2026-07-27T16:54:14Z

/test agentic-staging

openshift-trt-agent · 2026-07-27T17:16:28Z

Sippy Staging Environment

URL: https://lenses-attacks-suspended-ghz.trycloudflare.com

This environment is built from this PR and will remain available for approximately 60 minutes (until ~18:16 UTC).

smg247 · 2026-07-27T17:43:22Z

/lgtm

smg247 · 2026-07-27T17:43:28Z

/test e2e

openshift-ci · 2026-07-27T17:44:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-trt-agent[bot], smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2026

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 23, 2026

openshift-ci Bot requested review from deads2k and neisw July 23, 2026 20:35

openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2026

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2026

coderabbitai Bot approved these changes Jul 23, 2026

View reviewed changes

Revert npm audit threshold change per review feedback

4323380

The --audit-level=high workaround is unnecessary since PR openshift#3820 upgrades react-router-dom to resolve the moderate-severity CVEs directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci Bot assigned smg247 Jul 27, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2026

openshift-merge-bot Bot merged commit a0cf63d into openshift:main Jul 27, 2026
10 of 11 checks passed

Uh oh!

Conversation

openshift-trt-agent Bot commented Jul 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

openshift-ci-robot commented Jul 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

smg247 commented Jul 23, 2026

Uh oh!

smg247 commented Jul 23, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

❌ Failed checks (2 warnings)

Uh oh!

openshift-trt-agent Bot commented Jul 24, 2026

Uh oh!

smg247 commented Jul 24, 2026

Uh oh!

openshift-trt-agent Bot commented Jul 24, 2026

Uh oh!

smg247 commented Jul 24, 2026

Uh oh!

smg247 commented Jul 25, 2026

Uh oh!

smg247 commented Jul 27, 2026

Uh oh!

openshift-trt-agent Bot commented Jul 27, 2026

Sippy Staging Environment

Uh oh!

smg247 commented Jul 27, 2026

Uh oh!

smg247 commented Jul 27, 2026

Uh oh!

openshift-ci Bot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openshift-trt-agent Bot commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 23, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading