diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e917c92..a59da172 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -243,3 +243,6 @@ * Point `scripts/run_benchmark/wehi_hpc/run_full_hpc.sh` at `build/main` instead of `build/update_ilisi`, and label the seqera full run as `full` instead of `test_subset` (PR #129). + +* Fix `average_batch_r2` and `flowsom_mapping_similarity` writing `metric_ids` and `metric_values` + as scalars instead of lists, as required by `file_score.yaml` (PR #130). diff --git a/src/metrics/average_batch_r2/script.py b/src/metrics/average_batch_r2/script.py index 93fbd620..80b1c12e 100644 --- a/src/metrics/average_batch_r2/script.py +++ b/src/metrics/average_batch_r2/script.py @@ -84,8 +84,8 @@ uns={ "dataset_id": integrated_s1.uns["dataset_id"], "method_id": integrated_s1.uns["method_id"], - "metric_ids": "average_batch_r2_ct", - "metric_values": average_batch_r2_ct, + "metric_ids": ["average_batch_r2_ct"], + "metric_values": [average_batch_r2_ct], "r2_collection_ct": r2_collection_ct, } ) diff --git a/src/metrics/flowsom_mapping_similarity/script.R b/src/metrics/flowsom_mapping_similarity/script.R index fa1a268a..2e246b83 100644 --- a/src/metrics/flowsom_mapping_similarity/script.R +++ b/src/metrics/flowsom_mapping_similarity/script.R @@ -144,8 +144,8 @@ output <- anndata::AnnData( uns = list( dataset_id = integrated_s1$uns$dataset_id, method_id = integrated_s1$uns$method_id, - metric_ids = "flowsom_mean_mapping_similarity", - metric_values = fs_mapping_similarity_avg, + metric_ids = list("flowsom_mean_mapping_similarity"), + metric_values = list(fs_mapping_similarity_avg), fsom_absdiff_by_donor_refsplit = fsom_absdiff_by_donor_refsplit, fsom_parameters = list( "xdim" = grid_xdim,