fixup! diagnostics_channel: replace using with try-finally

Signed-off-by: Ayush Chaudhary <ayush23chaudhary@gmail.com>

Author: ayush23chaudhary

lib/diagnostics_channel.js

@@ -20,6 +20,7 @@ const {
 } = primordials;
 
 const {
+  aggregateTwoErrors,
   codes: {
     ERR_INVALID_ARG_TYPE,
   },
@@ -84,6 +85,19 @@ function maybeMarkInactive(channel) {
   }
 }
 
+function disposeStoreScopes(stack, error, hasError = false) {
+  for (let i = stack.length - 1; i >= 0; i--) {
+    try {
+      stack[i][SymbolDispose]();
+    } catch (err) {
+      error = hasError ? aggregateTwoErrors(err, error) : err;
+      hasError = true;
+    }
+  }
+
+  if (hasError) throw error;
+}
+
 class RunStoresScope {
   #stack;
 
@@ -109,7 +123,11 @@ class RunStoresScope {
           }
         }
 
-        ArrayPrototypePush(stack, store.withScope(newContext));
+        try {
+          ArrayPrototypePush(stack, store.withScope(newContext));
+        } catch (err) {
+          disposeStoreScopes(stack, err, true);
+        }
       }
     }
 
@@ -126,9 +144,7 @@ class RunStoresScope {
       const stack = this.#stack;
       this.#stack = undefined;
 
-      for (let i = stack.length - 1; i >= 0; i--) {
-        stack[i][SymbolDispose]();
-      }
+      disposeStoreScopes(stack);
     }
   }
 }
@@ -673,4 +689,4 @@ module.exports = {
   boundedChannel,
   Channel,
   BoundedChannel,
-};
+};