Skip to content

Memory Leak when the user closes the dialog shown via FragNavController.showDialogFragment #246

Description

@artsmvch

I was profiling my app and noticed that my closed dialog is not being garbage collected. Then I checked the references and found out that the FragNavController was holding a ref, namely the mCurrentDialogFrag field.
I suggest you make a weak reference to the current dialog frag instead of a strong reference for such cases.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions