Allow building mysqlclient without server deps - #680
Conversation
Currently when I only want to build the mysqlclient library I'm forced to also provide the ncurses/readline and rpc, but the client does not need those. With these changes will check if the `WITHOUT_SERVER` flag is set and skip those checks. Building the client still works this way. Signed-off-by: BlackDex <black.dex@gmail.com>
d7a5b96 to
f441cfa
Compare
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
@mysql-oca-bot I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, Thanks for the patch. The direction makes sense: a client-only build should not need to discover dependencies used exclusively by server code. However, I can’t accept this change as-is. The RPC change looks appropriately scoped, but the editline part needs a more complete solution—either retain editline configuration for client programs, or introduce a genuinely library-only build configuration that excludes them. |
3 participants
Currently when I only want to build the mysqlclient library I'm forced to also provide the ncurses/readline and rpc, but the client does not need those.
With these changes will check if the
WITHOUT_SERVERflag is set and skip those checks. Building the client still works this way.I'm not sure if this might have other implications though with other parts of libraries able to build this way, but I think this should be fine.