🧪 Cherry-pick: Add tier1 tests for cluster-level RBAC subject types (#588)#626
Open
RanWurmbrand wants to merge 1 commit into
Open
🧪 Cherry-pick: Add tier1 tests for cluster-level RBAC subject types (#588)#626RanWurmbrand wants to merge 1 commit into
RanWurmbrand wants to merge 1 commit into
Conversation
* Add tier1 tests for cluster-level RBAC subject types Add e2e tests covering ClusterRoleBinding subject variations: - MTA-857: ServiceAccount subject type - MTA-858: User subject type - MTA-859: Group subject type Signed-off-by: Ran Wurmbrand <rwurmbra@redhat.com> * addressed coderabit comments Signed-off-by: Ran Wurmbrand <rwurmbra@redhat.com> * addressed comments Signed-off-by: Ran Wurmbrand <rwurmbra@redhat.com> --------- Signed-off-by: Ran Wurmbrand <rwurmbra@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage ReportTotal: 47.8% Per-package coverage
Full function-level detailsPosted by CI |
RanWurmbrand
changed the title
Member
|
A few cosmetic nits inherited from the original #588:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #588 into release-0.10