From 9684782a64b8d09ecc83ecd69434d7dfa59d4c9a Mon Sep 17 00:00:00 2001 From: Sam Van Campenhout Date: Thu, 17 Sep 2026 15:24:56 +0200 Subject: [PATCH 1/2] Silence a linting issue that blocks CI The test uses an `assert.expect` call which is linted against. --- .../test-app/tests/integration/configuration/focus-trap-test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/test-app/tests/integration/configuration/focus-trap-test.js b/packages/test-app/tests/integration/configuration/focus-trap-test.js index ce6b1a95..45a2ea2a 100644 --- a/packages/test-app/tests/integration/configuration/focus-trap-test.js +++ b/packages/test-app/tests/integration/configuration/focus-trap-test.js @@ -94,6 +94,7 @@ module('Configuration | focus trap', function (hooks) { assert.verifySteps(['onActivate was called']); }); + // eslint-disable-next-line qunit/require-expect test('local focus trap options override service options', async function (assert) { assert.expect(2); From af85767e275f999ce618518bcddcc40365f1f2c2 Mon Sep 17 00:00:00 2001 From: Sam Van Campenhout Date: Mon, 21 Sep 2026 13:55:24 +0200 Subject: [PATCH 2/2] Unpin ember-modifier It seems this was pinned to a specific version by accident which causes package manangers to install multiple v4 versions if apps depend on a different one. --- packages/ember-promise-modals/package.json | 2 +- pnpm-lock.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ember-promise-modals/package.json b/packages/ember-promise-modals/package.json index ca49e1ad..fe810d74 100644 --- a/packages/ember-promise-modals/package.json +++ b/packages/ember-promise-modals/package.json @@ -50,7 +50,7 @@ "@embroider/util": "^1.13.3", "@glimmer/tracking": "^1.1.2", "decorator-transforms": "^2.0.0", - "ember-modifier": "4.2.2", + "ember-modifier": "^4.2.2", "focus-trap": "^7.0.0", "tracked-built-ins": "^4.0.0" }, diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index bd92da62..8370839b 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -36,7 +36,7 @@ importers: specifier: ^2.0.0 version: 2.3.0(@babel/core@7.28.5) ember-modifier: - specifier: 4.2.2 + specifier: ^4.2.2 version: 4.2.2(@babel/core@7.28.5) focus-trap: specifier: ^7.0.0