Skip to content

Commit 4dae650

Browse files
authored
Fix Dart Analyze and Android CI on Flutter 3.50 (#1291)
## Problem CI uses the unpinned `stable` Flutter channel, which is now 3.50.0. Two jobs fail on `main` since then, and so on every PR. **Dart Analyze.** Flutter 3.50 deprecates `package:flutter/material.dart` in favor of the `material_ui` package. `flutter analyze` reports 22 `deprecated_member_use` infos (6 in `lib/`, 16 in `example/`) and treats infos as fatal. **Android.** `flutter build apk` in `example/` stops with: ``` Your project's Gradle version (9.1.0) is lower than Flutter's minimum supported version of 9.3.1 ``` Flutter 3.50 also rejects the example's Android Gradle plugin (9.0.1, needs 9.1.1 or newer) and Kotlin Gradle plugin (2.3.20, needs 2.4.10 or newer). ## Change **Analyze** - Five of the six `lib/` files never used anything from Material. They now import `package:flutter/widgets.dart`. - `screen_select_dialog.dart` keeps the Material import with `ignore_for_file: deprecated_member_use`. `ScreenSelectDialog` extends `Dialog`, which is public API. The ignore is file level because the import sorter moves a line level ignore away from the import. - The example keeps Material and ignores the info on each import. Moving to `material_ui` is not an option yet. Every version of it needs Flutter 3.44 or newer (3.47 from 1.4.0 on), and this package supports 3.38. It would also add `cupertino_ui`, `flutter_localizations` and `intl ^0.20.2` as dependencies. **Android** - Gradle wrapper 9.1.0 to 9.5.0 - Android Gradle plugin 9.0.1 to 9.3.1 - Kotlin Gradle plugin 2.3.20 to 2.4.20 These are the versions the Flutter 3.50 app template uses. The minimums (9.3.1, 9.1.1, 2.4.10) would build but warn. ## Testing Locally on macOS with JDK 17. - Flutter 3.50.0: `flutter analyze`, `dart analyze web/`, `dart format . --set-exit-if-changed`, the import sorter, `check_version`, `flutter test`, and `flutter build apk` in `example/` - Flutter 3.47.1: `flutter build apk` in `example/` - Flutter 3.38.1: `flutter analyze lib` Not tested: the example Android build on Flutter 3.38 with the new versions. ## Notes - The changeset is there because `lib/` changed. Nothing changes for users, so it can be dropped if it is noise in the changelog. - Flutter 3.50 warns that the example app and the `flutter_background` and `flutter_webrtc` plugins apply the Kotlin Gradle plugin, and that a future Flutter will fail on it. Not addressed here.
1 parent d27f700 commit 4dae650

25 files changed

Lines changed: 32 additions & 24 deletions
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
patch type="changed" "Import package:flutter/widgets.dart instead of the deprecated package:flutter/material.dart wherever Material is not used, so the package analyzes cleanly on Flutter 3.50"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#Thu Nov 14 15:55:14 CST 2024
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
4-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-all.zip
4+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-all.zip
55
zipStoreBase=GRADLE_USER_HOME
66
zipStorePath=wrapper/dists

‎example/android/settings.gradle‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version '9.0.1' apply false
22-
id "org.jetbrains.kotlin.android" version "2.3.20" apply false
21+
id "com.android.application" version '9.3.1' apply false
22+
id "org.jetbrains.kotlin.android" version "2.4.20" apply false
2323
}
2424

2525
include ":app"

‎example/lib/exts.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:flutter/material.dart';
1+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
22

33
extension LKExampleExt on BuildContext {
44
//

‎example/lib/main.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:flutter/material.dart';
1+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
22
import 'package:livekit_client/livekit_client.dart';
33
import 'package:livekit_example/theme.dart';
44
import 'package:logging/logging.dart';

‎example/lib/pages/connect.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'dart:async';
22
import 'dart:convert';
33

4-
import 'package:flutter/material.dart';
4+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
55
import 'package:flutter_svg/flutter_svg.dart';
66
import 'package:livekit_client/livekit_client.dart';
77
import 'package:livekit_example/pages/connection_check.dart';

‎example/lib/pages/connection_check.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'dart:async';
22

3-
import 'package:flutter/material.dart';
3+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
44

55
import 'package:livekit_client/livekit_client.dart';
66

‎example/lib/pages/prejoin.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'dart:async';
22
import 'dart:math' as math;
33

44
import 'package:dropdown_button2/dropdown_button2.dart';
5-
import 'package:flutter/material.dart';
5+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
66
import 'package:livekit_client/livekit_client.dart';
77
import 'package:livekit_example/exts.dart';
88
import 'package:shared_preferences/shared_preferences.dart';

‎example/lib/pages/room.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'dart:async';
22
import 'dart:convert';
33

4-
import 'package:flutter/material.dart';
4+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
55
import 'package:flutter/services.dart';
66
import 'package:livekit_client/livekit_client.dart';
77

‎example/lib/theme.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:flutter/material.dart';
1+
import 'package:flutter/material.dart'; // ignore: deprecated_member_use
22
import 'package:google_fonts/google_fonts.dart';
33

44
//

0 commit comments

Comments
 (0)