Skip to content

chore: added esbuild plugin to support typescript for local dev and playwright test#88

Open
hsuehic wants to merge 1 commit into
lit:mainfrom
hsuehic:main
Open

chore: added esbuild plugin to support typescript for local dev and playwright test#88
hsuehic wants to merge 1 commit into
lit:mainfrom
hsuehic:main

Conversation

@hsuehic

@hsuehic hsuehic commented Mar 20, 2023 •
edited
Loading

Copy link
Copy Markdown

To dev locally without a compiling process, just using the web dev server to do the transform.

<!DOCTYPE html>

<html>
  <head>
    <meta charset="utf-8" />
    <title>&lt;my-element> Demo</title>
    <script type="module" src="../src/my-element.ts"></script>
    <style>
      p {
        border: solid 1px blue;
        padding: 8px;
      }
    </style>
  </head>
  <body>
    <my-element>
      <p>This is child content</p>
    </my-element>
  </body>
</html>

Encountered issue (Chrome devtool console) the following issue, when running

npm run serve

image

I added esbuild plugin to solve the issue.

@google-cla

google-cla Bot commented Mar 20, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hsuehic hsuehic force-pushed the main branch 2 times, most recently from 0cfdffe to 2053ff1 Compare March 21, 2023 10:09
polRk
polRk reviewed Nov 1, 2023
View reviewed changes
Comment thread web-dev-server.config.js
jsx: true,
ts: true,
tsx: true,
jsxFactory: 'React.createElement',

@polRk polRk Nov 1, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react ?

polRk
polRk reviewed Nov 1, 2023
View reviewed changes
Comment thread web-dev-server.config.js
tsx: true,
jsxFactory: 'React.createElement',
jsxFragment: 'Fragment',
target: 'es2020',

@polRk polRk Nov 1, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in tsconfig.json target is es2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@polRk polRk polRk left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hsuehic @polRk